[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.17-1283-gcf603cf
eric at webkit.org
eric at webkit.org
Tue Jan 5 23:46:32 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 4de37845d59ef8b4d5e8a98acb74dd340a371c0e
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Dec 10 08:18:05 2009 +0000
2009-12-10 Eric Seidel <eric at webkit.org>
Reviewed by Adam Barth.
bugzilla-tool "builders are red" error should tell you which builders
https://bugs.webkit.org/show_bug.cgi?id=32211
* Scripts/modules/buildsteps.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 92b3239..c460ff9 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,12 @@
+2009-12-10 Eric Seidel <eric at webkit.org>
+
+ Reviewed by Adam Barth.
+
+ bugzilla-tool "builders are red" error should tell you which builders
+ https://bugs.webkit.org/show_bug.cgi?id=32211
+
+ * Scripts/modules/buildsteps.py:
+
2009-12-09 Marwan Al Jubeh <marwan.aljubeh at gmail.com>
Reviewed by Adam Roben.
diff --git a/WebKitTools/Scripts/modules/buildsteps.py b/WebKitTools/Scripts/modules/buildsteps.py
index 8342562..425b912 100644
--- a/WebKitTools/Scripts/modules/buildsteps.py
+++ b/WebKitTools/Scripts/modules/buildsteps.py
@@ -137,8 +137,11 @@ class EnsureBuildersAreGreenStep(AbstractStep):
def run(self):
if not self._options.check_builders:
return
- if not self._tool.buildbot.core_builders_are_green():
- error("Builders at %s are red, please do not commit. Pass --ignore-builders to bypass this check." % (self._tool.buildbot.buildbot_host))
+ red_builders_names = self._tool.buildbot.red_core_builders_names()
+ if not red_builders_names:
+ return
+ red_builders_names = map(lambda name: "\"%s\"" % name, red_builders_names) # Add quotes around the names.
+ error("Builders [%s] are red, please do not commit.\nSee http://%s.\nPass --ignore-builders to bypass this check." % (", ".join(red_builders_names), self._tool.buildbot.buildbot_host))
class BuildStep(AbstractStep):
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list