[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.17-1283-gcf603cf
ap at apple.com
ap at apple.com
Tue Jan 5 23:47:01 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit d16704675acbacaeec53e6168c4c7c52633543bc
Author: ap at apple.com <ap at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Dec 11 00:41:10 2009 +0000
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32140
REGRESSION(r50072): Mailman administrative functionality is broken
Test: http/tests/misc/percent-sign-in-form-field-name.html
* platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent
sign, we never had a good reason to do that.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index d9f580b..d03903d 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2009-12-10 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=32140
+ REGRESSION(r50072): Mailman administrative functionality is broken
+
+ * http/tests/misc/percent-sign-in-form-field-name-expected.txt: Added.
+ * http/tests/misc/percent-sign-in-form-field-name.html: Added.
+ * http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi: Added.
+
2009-12-10 Kenneth Russell <kbr at google.com>
Reviewed by Oliver Hunt.
diff --git a/LayoutTests/http/tests/misc/percent-sign-in-form-field-name-expected.txt b/LayoutTests/http/tests/misc/percent-sign-in-form-field-name-expected.txt
new file mode 100644
index 0000000..d0a69ef
--- /dev/null
+++ b/LayoutTests/http/tests/misc/percent-sign-in-form-field-name-expected.txt
@@ -0,0 +1,3 @@
+Test for bug 32140: Mailman administrative functionality is broken.
+
+PASS
diff --git a/LayoutTests/http/tests/misc/percent-sign-in-form-field-name.html b/LayoutTests/http/tests/misc/percent-sign-in-form-field-name.html
new file mode 100644
index 0000000..91f3fa3
--- /dev/null
+++ b/LayoutTests/http/tests/misc/percent-sign-in-form-field-name.html
@@ -0,0 +1,10 @@
+<form method="post" action="resources/percent-sign-in-form-data-field-name.cgi" enctype="multipart/form-data">
+<input type="text" name="abc%40def" value="test">
+</form>
+<script>
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+}
+document.forms[0].submit();
+</script>
diff --git a/LayoutTests/http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi b/LayoutTests/http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi
new file mode 100755
index 0000000..717dad1
--- /dev/null
+++ b/LayoutTests/http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi
@@ -0,0 +1,26 @@
+#!/usr/bin/perl -w
+
+print "Content-type: text/html\n\n";
+
+print "<p>Test for <a href='https://bugs.webkit.org/show_bug.cgi?id=32140'>bug 32140</a>: Mailman administrative functionality is broken.</p>";
+print "<pre>";
+
+if ($ENV{'REQUEST_METHOD'} eq "POST") {
+ read(STDIN, $request, $ENV{'CONTENT_LENGTH'})
+ || die "Could not get query\n";
+ print $request;
+} else {
+ print "Wrong method: " . $ENV{'REQUEST_METHOD'} . "\n";
+}
+
+print "</pre><script>\n";
+print "var pre = document.getElementsByTagName('pre')[0];\n";
+print "if (pre.textContent.match('abc%40def'))\n";
+print " document.write('PASS')\n";
+print "else\n";
+print " document.write('FAIL')\n";
+print "if (window.layoutTestController) {\n";
+print " pre.setAttribute('style', 'display:none');\n";
+print " layoutTestController.notifyDone();\n";
+print "}\n";
+print "</script>\n";
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index f4823f1..67567ab 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2009-12-10 Alexey Proskuryakov <ap at apple.com>
+
+ Reviewed by Darin Adler.
+
+ https://bugs.webkit.org/show_bug.cgi?id=32140
+ REGRESSION(r50072): Mailman administrative functionality is broken
+
+ Test: http/tests/misc/percent-sign-in-form-field-name.html
+
+ * platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent
+ sign, we never had a good reason to do that.
+
2009-12-10 Kent Hansen <kent.hansen at nokia.com>
Reviewed by Geoffrey Garen.
diff --git a/WebCore/platform/network/FormDataBuilder.cpp b/WebCore/platform/network/FormDataBuilder.cpp
index 15f6c49..52f62f3 100644
--- a/WebCore/platform/network/FormDataBuilder.cpp
+++ b/WebCore/platform/network/FormDataBuilder.cpp
@@ -127,9 +127,6 @@ static void appendQuotedString(Vector<char>& buffer, const CString& string)
case '"':
append(buffer, "%22");
break;
- case '%':
- append(buffer, "%25");
- break;
default:
append(buffer, c);
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list