[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.17-1283-gcf603cf
abarth at webkit.org
abarth at webkit.org
Tue Jan 5 23:50:42 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 76797d3cba601412b900cd7c0256ace9a32fcfbb
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Dec 16 07:21:56 2009 +0000
Unreviewed fix for the style-queue.
Typo: _updates_status -> _update_status
We need to improve our testing infrastructure for the queues.
* Scripts/modules/commands/queues.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index edb7bb5..2a3cdfa 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,5 +1,14 @@
2009-12-15 Adam Barth <abarth at webkit.org>
+ Unreviewed fix for the style-queue.
+ Typo: _updates_status -> _update_status
+
+ We need to improve our testing infrastructure for the queues.
+
+ * Scripts/modules/commands/queues.py:
+
+2009-12-15 Adam Barth <abarth at webkit.org>
+
Unreviewed fix for the style-queue. I suspect this is a recent
regression from Eric's change below.
diff --git a/WebKitTools/Scripts/modules/commands/queues.py b/WebKitTools/Scripts/modules/commands/queues.py
index 1528dd8..96377ca 100644
--- a/WebKitTools/Scripts/modules/commands/queues.py
+++ b/WebKitTools/Scripts/modules/commands/queues.py
@@ -59,7 +59,7 @@ class AbstractQueue(Command, WorkQueueDelegate):
except Exception, e:
log("Failed to CC watchers: %s." % e)
- def _updates_status(self, message, patch, results_file=None):
+ def _update_status(self, message, patch, results_file=None):
self.tool.status_bot.update_status(self.name, message, patch, results_file)
def queue_log_path(self):
@@ -121,7 +121,7 @@ class CommitQueue(AbstractQueue, StepSequenceErrorHandler):
def next_work_item(self):
patches = self.tool.bugs.fetch_patches_from_commit_queue(reject_invalid_patches=True)
if not patches:
- self._updates_status("Empty queue.", None)
+ self._update_status("Empty queue.", None)
return None
# Only bother logging if we have patches in the queue.
self.log_progress([patch['id'] for patch in patches])
@@ -131,9 +131,9 @@ class CommitQueue(AbstractQueue, StepSequenceErrorHandler):
red_builders_names = self.tool.buildbot.red_core_builders_names()
if red_builders_names:
red_builders_names = map(lambda name: "\"%s\"" % name, red_builders_names) # Add quotes around the names.
- self._updates_status("Builders [%s] are red. See http://build.webkit.org." % ", ".join(red_builders_names), None)
+ self._update_status("Builders [%s] are red. See http://build.webkit.org." % ", ".join(red_builders_names), None)
return False
- self._updates_status("Landing patch %s from bug %s." % (patch["id"], patch["bug_id"]), patch)
+ self._update_status("Landing patch %s from bug %s." % (patch["id"], patch["bug_id"]), patch)
return True
def process_work_item(self, patch):
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list