[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.17-1283-gcf603cf
dbates at webkit.org
dbates at webkit.org
Wed Jan 6 00:08:47 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 286aa1a528df58dc622ee1451e73f70ce1179872
Author: dbates at webkit.org <dbates at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue Dec 29 08:30:18 2009 +0000
2009-12-29 Daniel Bates <dbates at webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32778
Changes $diffPercentage to be a number to resolve Perl
warning about comparing a string to a number.
* Scripts/run-webkit-tests:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index c18f3f3..5936e60 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,14 @@
+2009-12-29 Daniel Bates <dbates at webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ https://bugs.webkit.org/show_bug.cgi?id=32778
+
+ Changes $diffPercentage to be a number to resolve Perl
+ warning about comparing a string to a number.
+
+ * Scripts/run-webkit-tests:
+
2009-12-29 Jakub Wieczorek <faw217 at gmail.com>
Reviewed by Eric Seidel.
diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests
index 8709946..74766f0 100755
--- a/WebKitTools/Scripts/run-webkit-tests
+++ b/WebKitTools/Scripts/run-webkit-tests
@@ -708,7 +708,7 @@ for my $test (@tests) {
my $actualPNG = "";
my $diffPNG = "";
- my $diffPercentage = "";
+ my $diffPercentage = 0;
my $diffResult = "passed";
my $actualHash = "";
@@ -762,12 +762,12 @@ for my $test (@tests) {
}
if (/^diff: (.+)% (passed|failed)/) {
- $diffPercentage = $1;
+ $diffPercentage = $1 + 0;
$imageDifferences{$base} = $diffPercentage;
$diffResult = $2;
}
- if ($diffPercentage == 0) {
+ if (!$diffPercentage) {
printFailureMessageForTest($test, "pixel hash failed (but pixel test still passes)");
}
} elsif ($verbose) {
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list