[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.18-1-697-g2f78b87

[eric at webkit.org]

The following commit has been merged in the debian/unstable branch:
commit 7d9b46093ad88a8cd1f0c04e152c5dd419e30c1a
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Jan 9 07:40:02 2010 +0000

    2010-01-08  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Dmitry Titov.
    
            bindings/v8/DOMData is missing a virtual destructor
            https://bugs.webkit.org/show_bug.cgi?id=33390
    
            DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
            but it does not have a virtual destructor. While this isn't currently causing
            any leaks, since there are no instances of ChildThreadDOMData or
            MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
            compiler generates the following compilation error:
    
            "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
            functions and accessible non-virtual destructor"
    
            We therefore need to add a virtual destructor to DOMData.
    
            * bindings/v8/DOMData.cpp:
            (WebCore::DOMData::~DOMData):
            * bindings/v8/DOMData.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 8b04b5a..d3f8f0c 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,25 @@
+2010-01-08  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Dmitry Titov.
+
+        bindings/v8/DOMData is missing a virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=33390
+
+        DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
+        but it does not have a virtual destructor. While this isn't currently causing
+        any leaks, since there are no instances of ChildThreadDOMData or
+        MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
+        compiler generates the following compilation error:
+
+        "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
+        functions and accessible non-virtual destructor"
+
+        We therefore need to add a virtual destructor to DOMData.
+
+        * bindings/v8/DOMData.cpp:
+        (WebCore::DOMData::~DOMData):
+        * bindings/v8/DOMData.h:
+
 2010-01-08  Daniel Bates  <dbates at webkit.org>
 
         Reviewed by Adam Barth.
diff --git a/WebCore/bindings/v8/DOMData.cpp b/WebCore/bindings/v8/DOMData.cpp
index 54bcc55..ec9a938 100644
--- a/WebCore/bindings/v8/DOMData.cpp
+++ b/WebCore/bindings/v8/DOMData.cpp
@@ -44,6 +44,10 @@ DOMData::DOMData()
 {
 }
 
+DOMData::~DOMData()
+{
+}
+
 DOMData* DOMData::getCurrent()
 {
     if (WTF::isMainThread())
diff --git a/WebCore/bindings/v8/DOMData.h b/WebCore/bindings/v8/DOMData.h
index b58f138..93480ca 100644
--- a/WebCore/bindings/v8/DOMData.h
+++ b/WebCore/bindings/v8/DOMData.h
@@ -45,6 +45,7 @@ namespace WebCore {
     class DOMData : public Noncopyable {
     public:
         DOMData();
+        virtual ~DOMData();
 
         static DOMData* getCurrent();
         virtual DOMDataStore& getStore() = 0;

-- 
WebKit Debian packaging