[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.18-1-697-g2f78b87

[kov at webkit.org]

The following commit has been merged in the debian/unstable branch:
commit 28fe3462de1db93a3ffadb0672c8165ac7a7a252
Author: kov at webkit.org <kov at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Jan 11 15:15:30 2010 +0000

            Reviewed by Xan Lopez.
    
            [GTK] couple fixes for signal emissions, and property notifications
            https://bugs.webkit.org/show_bug.cgi?id=33428
    
            Fix commitedLoad being called where it should not, causing it to
            be called one time too many in some cases. We now match Qt's and
            Mac's behavior here.
    
            * WebCoreSupport/FrameLoaderClientGtk.cpp:
            (WebKit::FrameLoaderClient::finishedLoading):
            * tests/testloading.c:
            (load_error_status_changed_cb):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 6d446a3..aa7041f 100644
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,19 @@
+2010-01-11  Gustavo Noronha Silva  <gns at gnome.org>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] couple fixes for signal emissions, and property notifications
+        https://bugs.webkit.org/show_bug.cgi?id=33428
+
+        Fix commitedLoad being called where it should not, causing it to
+        be called one time too many in some cases. We now match Qt's and
+        Mac's behavior here.
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit::FrameLoaderClient::finishedLoading):
+        * tests/testloading.c:
+        (load_error_status_changed_cb):
+
 2010-01-08  Gustavo Noronha Silva  <gns at gnome.org>
 
         Reviewed by Xan Lopez.
diff --git a/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp b/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
index a690d80..4d53501 100644
--- a/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
+++ b/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp
@@ -840,9 +840,10 @@ String FrameLoaderClient::generatedMIMETypeForURLScheme(const String&) const
 
 void FrameLoaderClient::finishedLoading(WebCore::DocumentLoader* documentLoader)
 {
-    if (!m_pluginView)
-        committedLoad(documentLoader, 0, 0);
-    else {
+    if (!m_pluginView) {
+        FrameLoader* loader = documentLoader->frameLoader();
+        loader->setEncoding(m_response.textEncodingName(), false);
+    } else {
         m_pluginView->didFinishLoading();
         m_pluginView = 0;
         m_hasSentResponseToPlugin = false;
diff --git a/WebKit/gtk/tests/testloading.c b/WebKit/gtk/tests/testloading.c
index 34897bb..cb800c3 100644
--- a/WebKit/gtk/tests/testloading.c
+++ b/WebKit/gtk/tests/testloading.c
@@ -175,6 +175,10 @@ static void load_error_status_changed_cb(GObject* object, GParamSpec* pspec, Web
          * anything */
         fixture->has_been_provisional = TRUE;
         break;
+    case WEBKIT_LOAD_COMMITTED:
+        g_assert(!fixture->has_been_committed);
+        fixture->has_been_committed = TRUE;
+        break;
     case WEBKIT_LOAD_FINISHED:
         g_assert(fixture->has_been_provisional);
         g_assert(fixture->has_been_load_error);

-- 
WebKit Debian packaging