[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.18-1-697-g2f78b87

[eric at webkit.org]

The following commit has been merged in the debian/unstable branch:
commit 8129c635b813ad2e6039cff960615291de55e00f
Author: eric at webkit.org <eric at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jan 12 12:31:44 2010 +0000

    2010-01-12  Eric Seidel  <eric at webkit.org>
    
            Reviewed by Adam Barth.
    
            AssignToCommitter does not need to fetch bugs twice
            https://bugs.webkit.org/show_bug.cgi?id=33530
    
            This is a no-brainer patch now that we've added Bug.reviewed_patches
    
            * Scripts/webkitpy/commands/upload.py:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index f20faab..4071b46 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -2,6 +2,17 @@
 
         Reviewed by Adam Barth.
 
+        AssignToCommitter does not need to fetch bugs twice
+        https://bugs.webkit.org/show_bug.cgi?id=33530
+
+        This is a no-brainer patch now that we've added Bug.reviewed_patches
+
+        * Scripts/webkitpy/commands/upload.py:
+
+2010-01-12  Eric Seidel  <eric at webkit.org>
+
+        Reviewed by Adam Barth.
+
         bugzilla.py should have an Attachment object instead of passing around dictionaries
         https://bugs.webkit.org/show_bug.cgi?id=31594
 
diff --git a/WebKitTools/Scripts/webkitpy/commands/upload.py b/WebKitTools/Scripts/webkitpy/commands/upload.py
index 870c4b1..0f84b95 100644
--- a/WebKitTools/Scripts/webkitpy/commands/upload.py
+++ b/WebKitTools/Scripts/webkitpy/commands/upload.py
@@ -67,8 +67,7 @@ class AssignToCommitter(AbstractDeclarativeCommand):
             log("Bug %s is already assigned to %s (%s)." % (bug_id, assigned_to_email, committers.committer_by_email(assigned_to_email)))
             return
 
-        # FIXME: This should call a reviewed_patches() method on bug instead of re-fetching.
-        reviewed_patches = self.tool.bugs.fetch_bug(bug_id).reviewed_patches()
+        reviewed_patches = bug.reviewed_patches()
         if not reviewed_patches:
             log("Bug %s has no non-obsolete patches, ignoring." % bug_id)
             return

-- 
WebKit Debian packaging