[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.18-1-697-g2f78b87

[kevino at webkit.org]

The following commit has been merged in the debian/unstable branch:
commit 560db796082d02067a93665132c2b372b5db02b0
Author: kevino at webkit.org <kevino at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Sat Jan 16 01:24:57 2010 +0000

    Reviewed by Alexey Proskuryakov.
    
    Move the code adding the child frame to the FrameTree into wxWebFrame constructor
    so that it happens before we call init() on the new frame. Fixes asserts checking
    frame count consistency.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/wx/ChangeLog b/WebKit/wx/ChangeLog
index a7a8295..e57a36d 100644
--- a/WebKit/wx/ChangeLog
+++ b/WebKit/wx/ChangeLog
@@ -1,3 +1,16 @@
+2010-01-15  Kevin Ollivier  <kevino at theolliviers.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Move the code adding the child frame to the FrameTree into wxWebFrame constructor
+        so that it happens before we call init() on the new frame. Fixes asserts checking
+        frame count consistency.
+
+        * WebFrame.cpp:
+        (wxWebFrame::wxWebFrame):
+        * WebKitSupport/FrameLoaderClientWx.cpp:
+        (WebCore::FrameLoaderClientWx::createFrame):
+
 2010-01-14  Kevin Ollivier  <kevino at theolliviers.com>
 
         [wx] Build fix, missing header.
diff --git a/WebKit/wx/WebFrame.cpp b/WebKit/wx/WebFrame.cpp
index 8e58e8d..da32aa3 100644
--- a/WebKit/wx/WebFrame.cpp
+++ b/WebKit/wx/WebFrame.cpp
@@ -92,6 +92,13 @@ wxWebFrame::wxWebFrame(wxWebView* container, wxWebFrame* parent, WebViewFrameDat
 
     m_impl->frame = newFrame.get();
 
+    if (data)
+        newFrame->tree()->setName(data->name);
+
+    // Subframes expect to be added to the FrameTree before init is called.
+    if (parentFrame)
+        parentFrame->document()->frame()->tree()->appendChild(newFrame.get());
+    
     loaderClient->setFrame(this);
     loaderClient->setWebView(container);
     
diff --git a/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp b/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp
index fbb4ec3..5bb4dc1 100644
--- a/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp
+++ b/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp
@@ -828,10 +828,6 @@ PassRefPtr<Frame> FrameLoaderClientWx::createFrame(const KURL& url, const String
 
     RefPtr<Frame> childFrame = adoptRef(newFrame->m_impl->frame);
 
-    m_frame->tree()->appendChild(childFrame);
-    childFrame->tree()->setName(name);
-    childFrame->init();
-
     // The creation of the frame may have run arbitrary JavaScript that removed it from the page already.
     if (!childFrame->page())
         return 0;

-- 
WebKit Debian packaging