[SCM] WebKit Debian packaging branch, debian/unstable, updated. debian/1.1.18-1-697-g2f78b87

[abarth at webkit.org]

The following commit has been merged in the debian/unstable branch:
commit 5b1300cf0e714b99c9be3651dde2b752e3efcc73
Author: abarth at webkit.org <abarth at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Jan 18 18:36:26 2010 +0000

    2010-01-18  Adam Barth  <abarth at webkit.org>
    
            Reviewed by Adam Roben.
    
            Rename patches-to-commit to patches-in-commit-queue
            https://bugs.webkit.org/show_bug.cgi?id=33789
    
            The command really lists the patches in the commit-queue not all the
            patches that are pending-commit (as the FIXME commands).
    
            * Scripts/webkitpy/commands/queries.py:
            * Scripts/webkitpy/commands/queries_unittest.py:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index b027008..04bc328 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,16 @@
+2010-01-18  Adam Barth  <abarth at webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Rename patches-to-commit to patches-in-commit-queue
+        https://bugs.webkit.org/show_bug.cgi?id=33789
+
+        The command really lists the patches in the commit-queue not all the
+        patches that are pending-commit (as the FIXME commands).
+
+        * Scripts/webkitpy/commands/queries.py:
+        * Scripts/webkitpy/commands/queries_unittest.py:
+
 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
 
         Reviewed by Simon Hausmann.
diff --git a/WebKitTools/Scripts/webkitpy/commands/queries.py b/WebKitTools/Scripts/webkitpy/commands/queries.py
index 2880172..3ca4f42 100644
--- a/WebKitTools/Scripts/webkitpy/commands/queries.py
+++ b/WebKitTools/Scripts/webkitpy/commands/queries.py
@@ -48,12 +48,11 @@ class BugsToCommit(AbstractDeclarativeCommand):
             print "%s" % bug_id
 
 
-class PatchesToCommit(AbstractDeclarativeCommand):
-    name = "patches-to-commit"
+class PatchesInCommitQueue(AbstractDeclarativeCommand):
+    name = "patches-in-commit-queue"
     help_text = "List patches in the commit-queue"
 
     def execute(self, options, args, tool):
-        # FIXME: This command is poorly named.  It's fetching the commit-queue list here.  The name implies it's fetching pending-commit (all r+'d patches).
         patches = tool.bugs.queries.fetch_patches_from_commit_queue()
         log("Patches in commit queue:")
         for patch in patches:
diff --git a/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py b/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py
index d42f363..9a14f9b 100644
--- a/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/commands/queries_unittest.py
@@ -39,10 +39,10 @@ class QueryCommandsTest(CommandsTest):
         expected_stderr = "Warning, attachment 128 on bug 42 has invalid committer (non-committer at example.com)\n"
         self.assert_execute_outputs(BugsToCommit(), None, "42\n77\n", expected_stderr)
 
-    def test_patches_to_commit(self):
+    def test_patches_in_commit_queue(self):
         expected_stdout = "http://example.com/197\nhttp://example.com/103\n"
         expected_stderr = "Warning, attachment 128 on bug 42 has invalid committer (non-committer at example.com)\nPatches in commit queue:\n"
-        self.assert_execute_outputs(PatchesToCommit(), None, expected_stdout, expected_stderr)
+        self.assert_execute_outputs(PatchesInCommitQueue(), None, expected_stdout, expected_stderr)
 
     def test_patches_to_commit_queue(self):
         expected_stdout = "http://example.com/104&action=edit\n"

-- 
WebKit Debian packaging