[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.22-985-g3c00f00
hamaji at chromium.org
hamaji at chromium.org
Wed Mar 17 17:58:09 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit 34bd30df82e7a61168a261fced6529ce273f5574
Author: hamaji at chromium.org <hamaji at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Feb 24 08:51:47 2010 +0000
2010-02-24 Shinichiro Hamaji <hamaji at chromium.org>
Reviewed by Darin Adler.
check-webkit-style false positive for WebCore forwarding header
https://bugs.webkit.org/show_bug.cgi?id=34604
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index e91b0d2..3eab2a5 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,13 @@
+2010-02-24 Shinichiro Hamaji <hamaji at chromium.org>
+
+ Reviewed by Darin Adler.
+
+ check-webkit-style false positive for WebCore forwarding header
+ https://bugs.webkit.org/show_bug.cgi?id=34604
+
+ * Scripts/webkitpy/style/checker.py:
+ * Scripts/webkitpy/style/checker_unittest.py:
+
2010-02-23 Alexey Proskuryakov <ap at apple.com>
Reviewed by Mark Rowe.
diff --git a/WebKitTools/Scripts/webkitpy/style/checker.py b/WebKitTools/Scripts/webkitpy/style/checker.py
index 32cded3..9c66b97 100644
--- a/WebKitTools/Scripts/webkitpy/style/checker.py
+++ b/WebKitTools/Scripts/webkitpy/style/checker.py
@@ -125,6 +125,10 @@ _PATH_RULES_SPECIFIER = [
"WebKitTools/DumpRenderTree/gtk/"],
["-readability/naming",
"-readability/null"]),
+ ([# Header files in ForwardingHeaders have no header guards or
+ # exceptional header guards (e.g., WebCore_FWD_Debugger_h).
+ "/ForwardingHeaders/"],
+ ["-build/header_guard"]),
]
diff --git a/WebKitTools/Scripts/webkitpy/style/checker_unittest.py b/WebKitTools/Scripts/webkitpy/style/checker_unittest.py
index cdd2ac4..1a54cec 100755
--- a/WebKitTools/Scripts/webkitpy/style/checker_unittest.py
+++ b/WebKitTools/Scripts/webkitpy/style/checker_unittest.py
@@ -136,6 +136,8 @@ class GlobalVariablesTest(unittest.TestCase):
assertNoCheck(
"JavaScriptCore/qt/tests/qscriptengine/tst_qscriptengine.cpp",
"readability/naming")
+ assertNoCheck("WebCore/ForwardingHeaders/debugger/Debugger.h",
+ "build/header_guard")
def test_max_reports_per_category(self):
"""Check that _MAX_REPORTS_PER_CATEGORY is valid."""
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list