[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.22-985-g3c00f00
sullivan at apple.com
sullivan at apple.com
Wed Mar 17 18:31:07 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit a37f86cb6edb214f76440f4284f3f4d772eda79f
Author: sullivan at apple.com <sullivan at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Mar 10 13:23:59 2010 +0000
<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>
Reviewed by Tim Hatcher.
WebKit/mac:
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementDoesAutoComplete:]):
Return true for any text field that's not a password, rather than only
for TEXT type.
WebKit/win:
* WebFrame.cpp:
(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
index cdee9ea..476786b 100644
--- a/WebKit/mac/ChangeLog
+++ b/WebKit/mac/ChangeLog
@@ -1,3 +1,15 @@
+2010-03-10 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ <rdar://problem/7735387> input type other than text won't work with autofill
+ <https://bugs.webkit.org/show_bug.cgi?id=35963>
+
+ * WebView/WebHTMLRepresentation.mm:
+ (-[WebHTMLRepresentation elementDoesAutoComplete:]):
+ Return true for any text field that's not a password, rather than only
+ for TEXT type.
+
2010-03-09 Brady Eidson <beidson at apple.com>
Reviewed by Tim Hatcher.
diff --git a/WebKit/mac/WebView/WebHTMLRepresentation.mm b/WebKit/mac/WebView/WebHTMLRepresentation.mm
index 3aaa914..2684004 100644
--- a/WebKit/mac/WebView/WebHTMLRepresentation.mm
+++ b/WebKit/mac/WebView/WebHTMLRepresentation.mm
@@ -302,7 +302,8 @@ static HTMLInputElement* inputElementFromDOMElement(DOMElement* element)
{
HTMLInputElement* inputElement = inputElementFromDOMElement(element);
return inputElement
- && inputElement->inputType() == HTMLInputElement::TEXT
+ && inputElement->isTextField()
+ && inputElement->inputType() != HTMLInputElement::PASSWORD
&& inputElement->autoComplete();
}
diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index 14de714..8819f78 100644
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,15 @@
+2010-03-10 John Sullivan <sullivan at apple.com>
+
+ Reviewed by Tim Hatcher.
+
+ <rdar://problem/7735387> input type other than text won't work with autofill
+ <https://bugs.webkit.org/show_bug.cgi?id=35963>
+
+ * WebFrame.cpp:
+ (WebFrame::elementDoesAutoComplete):
+ Return true for any text field that's not a password, rather than only
+ for TEXT type.
+
2010-03-09 Brady Eidson <beidson at apple.com>
Reviewed by Tim Hatcher.
diff --git a/WebKit/win/WebFrame.cpp b/WebKit/win/WebFrame.cpp
index 8b7e0fd..3ce4bd6 100644
--- a/WebKit/win/WebFrame.cpp
+++ b/WebKit/win/WebFrame.cpp
@@ -1152,7 +1152,7 @@ HRESULT WebFrame::elementDoesAutoComplete(IDOMElement *element, BOOL *result)
if (!inputElement)
*result = false;
else
- *result = (inputElement->inputType() == HTMLInputElement::TEXT && inputElement->autoComplete());
+ *result = inputElement->isTextField() && inputElement->inputType() != HTMLInputElement::PASSWORD && inputElement->autoComplete();
return S_OK;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list