[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.22-985-g3c00f00

[kov at webkit.org]

The following commit has been merged in the webkit-1.1 branch:
commit 88484229df1c447ebe1a9ea73365166f722f68ba
Author: kov at webkit.org <kov at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Mar 9 18:35:48 2010 +0000

    2010-03-09 Gustavo Noronha Silva <gustavo.noronha at collabora.co.uk>
    
    Reviewed by Dirk Schulze.
    
            [GStreamer] Buffering logic is not correct, and does not work very well
            https://bugs.webkit.org/show_bug.cgi?id=35706
    
            Do not call pause(), but set the GStreamer state directly. This is
            just a GStreamer implementation detail, and this will avoid having
            side effects in case we change the pause implementation in the
            future.
    
            * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
            (WebCore::MediaPlayerPrivate::load):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1c5669f..b5f0580 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2010-03-09  Gustavo Noronha Silva  <gustavo.noronha at collabora.co.uk>
+
+        Reviewed by Dirk Schulze.
+
+        [GStreamer] Buffering logic is not correct, and does not work very well
+        https://bugs.webkit.org/show_bug.cgi?id=35706
+
+        Do not call pause(), but set the GStreamer state directly. This is
+        just a GStreamer implementation detail, and this will avoid having
+        side effects in case we change the pause implementation in the
+        future.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivate::load):
+
 2010-03-09  Chris Fleizach  <cfleizach at apple.com>
 
         Reviewed by Darin Adler.
diff --git a/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
index 59731b9..aa20fa5 100644
--- a/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
+++ b/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
@@ -344,7 +344,10 @@ void MediaPlayerPrivate::load(const String& url)
     }
 
     g_object_set(m_playBin, "uri", url.utf8().data(), NULL);
-    pause();
+
+    // GStreamer needs to have the pipeline set to a paused state to
+    // start providing anything useful.
+    gst_element_set_state(m_playBin, GST_STATE_PAUSED);
 }
 
 bool MediaPlayerPrivate::changePipelineState(GstState newState)

-- 
WebKit Debian packaging