[SCM] WebKit Debian packaging branch, webkit-1.1, updated. upstream/1.1.22-985-g3c00f00
bdakin at apple.com
bdakin at apple.com
Wed Mar 17 18:37:39 UTC 2010
The following commit has been merged in the webkit-1.1 branch:
commit c084b7a438d0cb6d7820ac38b276c4584c6b24e3
Author: bdakin at apple.com <bdakin at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri Mar 12 23:17:12 2010 +0000
Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>
Reviewed by Adam Roben.
The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.
* FullscreenVideoController.cpp:
(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index 906ca0f..4436e21 100644
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,22 @@
+2010-03-12 Beth Dakin <bdakin at apple.com>
+
+ Reviewed by Adam Roben.
+
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
+ video HUD stays on top when switching to another window (e.g. via
+ Alt-Tab)
+ -and corresponding-
+ <rdar://problem/7547574>
+
+ The HUD was always on top because it had the WS_EX_TOPMOST style.
+ So I removed the style and made m_videoWindow the owner of
+ m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
+ is the focused window.
+
+ * FullscreenVideoController.cpp:
+ (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
+ (FullscreenVideoController::createHUDWindow):
+
2010-03-12 Enrica Casucci <enrica at apple.com>
Reviewed by Simon Fraser.
diff --git a/WebKit/win/FullscreenVideoController.cpp b/WebKit/win/FullscreenVideoController.cpp
index dbfc794..a4736f2 100644
--- a/WebKit/win/FullscreenVideoController.cpp
+++ b/WebKit/win/FullscreenVideoController.cpp
@@ -226,12 +226,12 @@ void FullscreenVideoController::enterFullscreen()
void FullscreenVideoController::exitFullscreen()
{
+ SetWindowLongPtr(m_hudWindow, 0, 0);
if (movie())
movie()->exitFullscreen();
+ ASSERT(!IsWindow(m_hudWindow));
m_videoWindow = 0;
- SetWindowLongPtr(m_hudWindow, 0, 0);
- DestroyWindow(m_hudWindow);
m_hudWindow = 0;
}
@@ -368,9 +368,9 @@ void FullscreenVideoController::createHUDWindow()
registerHUDWindowClass();
- m_hudWindow = CreateWindowEx(WS_EX_LAYERED | WS_EX_TRANSPARENT | WS_EX_TOPMOST | WS_EX_TOOLWINDOW,
+ m_hudWindow = CreateWindowEx(WS_EX_LAYERED | WS_EX_TRANSPARENT | WS_EX_TOOLWINDOW,
fullscreenVideeoHUDWindowClassName, 0, WS_POPUP | WS_VISIBLE,
- m_hudPosition.x(), m_hudPosition.y(), 0, 0, 0, 0, gInstance, 0);
+ m_hudPosition.x(), m_hudPosition.y(), 0, 0, m_videoWindow, 0, gInstance, 0);
ASSERT(::IsWindow(m_hudWindow));
SetWindowLongPtr(m_hudWindow, 0, reinterpret_cast<LONG_PTR>(this));
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list