[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198

bdakin at apple.com bdakin at apple.com
Sun Feb 20 22:46:04 UTC 2011


The following commit has been merged in the webkit-1.3 branch:
commit c06c0293ffab39a65a692fcc6017350a0d0dc3ef
Author: bdakin at apple.com <bdakin at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jan 11 04:14:51 2011 +0000

    Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=51119, transformed
    elements not responding properly to :hover after r73385.
    Just use the entire document area as the hit test area,
    since there appears to be a rounding bug/issues with relying
    on float math when mapping the hit test area into
    transformed coordinates.
    
    Patch by David Hyatt <hyatt at apple.com> on 2010-10-10
    Reviewed by Simon Fraser.
    
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::hitTest):
    
    LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=51119
    
    Patch by David Hyatt <hyatt at apple.com> on 2011-01-10
    Reviewed by Simon Fraser.
    
    * fast/transforms/transform-hit-test-flipped-expected.txt: Added.
    * fast/transforms/transform-hit-test-flipped.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index dca022e..20ce65c 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
+2011-01-10  David Hyatt  <hyatt at apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Test for https://bugs.webkit.org/show_bug.cgi?id=51119
+
+        * fast/transforms/transform-hit-test-flipped-expected.txt: Added.
+        * fast/transforms/transform-hit-test-flipped.html: Added.
+
 2011-01-10  Justin Schuh  <jschuh at chromium.org>
 
         Unreviewed Chromium test expectations update.
diff --git a/LayoutTests/compositing/overflow/get-transform-from-non-box-container-expected.txt b/LayoutTests/fast/transforms/transform-hit-test-flipped-expected.txt
similarity index 100%
copy from LayoutTests/compositing/overflow/get-transform-from-non-box-container-expected.txt
copy to LayoutTests/fast/transforms/transform-hit-test-flipped-expected.txt
diff --git a/LayoutTests/fast/transforms/transform-hit-test-flipped.html b/LayoutTests/fast/transforms/transform-hit-test-flipped.html
new file mode 100644
index 0000000..96ee935
--- /dev/null
+++ b/LayoutTests/fast/transforms/transform-hit-test-flipped.html
@@ -0,0 +1,33 @@
+<html>
+<head>
+<style>
+  #rotated {
+    width: 100px;
+    height: 100px;
+    background: red;
+    margin: 10px;
+    padding: 10px;
+    -webkit-transform: rotate(180deg);
+  }
+</style>
+<script>
+if (window.layoutTestController)
+  window.layoutTestController.dumpAsText()
+
+function runTest()
+{
+   document.body.offsetWidth;
+   var elt = document.elementFromPoint(50, 50);
+   if (elt == document.getElementById('rotated'))
+       document.getElementById('console').innerHTML = 'PASS';
+   else
+       document.getElementById('console').innerHTML = 'FAIL';
+   elt.style.display = 'none';
+}
+</script>
+</head>
+<body onload="runTest()">
+<div id="rotated">180 degree rotation</div>
+<div id="console"></div>
+</body>
+</html>
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index a10239d..1e53505 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-10-10  David Hyatt  <hyatt at apple.com>
+
+        Reviewed by Simon Fraser.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51119, transformed 
+        elements not responding properly to :hover after r73385.  
+        Just use the entire document area as the hit test area, 
+        since there appears to be a rounding bug/issues with relying 
+        on float math when mapping the hit test area into
+        transformed coordinates.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::hitTest):
+
 2011-01-10  Stephen White  <senorblanco at chromium.org>
 
         Reviewed by James Robinson.
diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
index bd954ed..541614c 100644
--- a/Source/WebCore/rendering/RenderLayer.cpp
+++ b/Source/WebCore/rendering/RenderLayer.cpp
@@ -2679,7 +2679,7 @@ bool RenderLayer::hitTest(const HitTestRequest& request, HitTestResult& result)
 {
     renderer()->document()->updateLayout();
     
-    IntRect hitTestArea = result.rectForPoint(result.point());
+    IntRect hitTestArea = renderer()->view()->documentRect();
     if (!request.ignoreClipping())
         hitTestArea.intersect(frameVisibleRect(renderer()));
 

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list