[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198
ojan at chromium.org
ojan at chromium.org
Sun Feb 20 22:52:48 UTC 2011
The following commit has been merged in the webkit-1.3 branch:
commit 491c65965c462e3784a1e8a03022b4fe2c54fcf0
Author: ojan at chromium.org <ojan at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Jan 12 22:58:31 2011 +0000
2011-01-12 Ojan Vafai <ojan at chromium.org>
Reviewed by Adam Barth.
show shared lines on both sides in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52308
We were appending the same DOM node twice. Instead, make
the from column a clone of the original node.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 75942ab..6e2ee04 100644
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -2,6 +2,18 @@
Reviewed by Adam Barth.
+ show shared lines on both sides in code review tool
+ https://bugs.webkit.org/show_bug.cgi?id=52308
+
+ We were appending the same DOM node twice. Instead, make
+ the from column a clone of the original node.
+
+ * code-review.js:
+
+2011-01-12 Ojan Vafai <ojan at chromium.org>
+
+ Reviewed by Adam Barth.
+
fix wrapping bug in expansion lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52270
diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 6836be2..b0786f7 100644
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -842,9 +842,13 @@
var to_class = '';
var from_attributes = '';
var to_attributes = '';
- var from_contents = contents;
+ // Clone the contents so we have two copies we can put back in the DOM.
+ var from_contents = contents.clone(true);
var to_contents = contents;
+ var container_class = 'LineContainer';
+ var container_attributes = '';
+
if (from && !to) { // This is a remove line.
from_class = classNames;
from_attributes = attributes;
@@ -853,11 +857,7 @@
to_class = classNames;
to_attributes = attributes;
from_contents = '';
- }
-
- var container_class = 'LineContainer';
- var container_attributes = '';
- if (!to_attributes && !from_attributes) {
+ } else {
container_attributes = attributes;
container_class += ' Line ' + classNames;
}
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list