[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198

ap at apple.com ap at apple.com
Sun Feb 20 23:07:53 UTC 2011


The following commit has been merged in the webkit-1.3 branch:
commit 09a2f3fc16e4ace4ccca9c14f175b084990a5aae
Author: ap at apple.com <ap at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Jan 18 00:32:59 2011 +0000

            Actually wrote a FIXME promised for a review comment.
    
            * UIProcess/API/mac/WKView.mm:
            (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
index eb21be7..92f9844 100644
--- a/Source/WebKit2/ChangeLog
+++ b/Source/WebKit2/ChangeLog
@@ -1,5 +1,12 @@
 2011-01-17  Alexey Proskuryakov  <ap at apple.com>
 
+        Actually wrote a FIXME promised for a review comment.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
+
+2011-01-17  Alexey Proskuryakov  <ap at apple.com>
+
         Reviewed by Anders Carlsson and Darin Adler.
 
         https://bugs.webkit.org/show_bug.cgi?id=52595
diff --git a/Source/WebKit2/UIProcess/API/mac/WKView.mm b/Source/WebKit2/UIProcess/API/mac/WKView.mm
index 6eccc6e..da9b7c9 100644
--- a/Source/WebKit2/UIProcess/API/mac/WKView.mm
+++ b/Source/WebKit2/UIProcess/API/mac/WKView.mm
@@ -1373,8 +1373,8 @@ static WebFrameProxy* frameBeingPrinted()
 // Take over printing. AppKit applies incorrect clipping, and doesn't print pages beyond the first one.
 - (void)_recursiveDisplayRectIfNeededIgnoringOpacity:(NSRect)rect isVisibleRect:(BOOL)isVisibleRect rectIsVisibleRectForView:(NSView *)visibleView topView:(BOOL)topView
 {
+    // FIXME: This check isn't right for some non-printing cases, such as capturing into a buffer using cacheDisplayInRect:toBitmapImageRep:.
     if ([NSGraphicsContext currentContextDrawingToScreen]) {
-        // FIXME: 
         _data->_page->endPrinting();
         [super _recursiveDisplayRectIfNeededIgnoringOpacity:rect isVisibleRect:isVisibleRect rectIsVisibleRectForView:visibleView topView:topView];
         return;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list