[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198

ojan at chromium.org ojan at chromium.org
Sun Feb 20 23:31:31 UTC 2011


The following commit has been merged in the webkit-1.3 branch:
commit 72ce9e32bc14c6b8e2ccab0513fdf21af12d8c70
Author: ojan at chromium.org <ojan at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Fri Jan 21 03:34:27 2011 +0000

    2011-01-20  Ojan Vafai  <ojan at chromium.org>
    
            Fix the review tool for image diffs. We would get a javascript error
            because image diffs don't have line numbers.
    
            * code-review.js:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index ee88f28..3127055 100644
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,5 +1,12 @@
 2011-01-20  Ojan Vafai  <ojan at chromium.org>
 
+        Fix the review tool for image diffs. We would get a javascript error
+        because image diffs don't have line numbers.
+
+        * code-review.js:
+
+2011-01-20  Ojan Vafai  <ojan at chromium.org>
+
         Reviewed by Oliver Hunt.
 
         Could review tool include style failure info?
diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index b103819..f113c74 100644
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -417,7 +417,7 @@ body {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=28"></script>
+<script src="code-review.js?version=29"></script>
 EOF
 
     def self.revisionOrDescription(string)
diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index 45b4bc8..79b4975 100644
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -346,6 +346,9 @@
 
   function firstLine(file_diff) {
     var container = $('.LineContainer:not(.context)', file_diff)[0];
+    if (!container)
+      return 0;
+
     var from = fromLineNumber(container);
     var to = toLineNumber(container);
     return from || to;

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list