[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198

yurys at chromium.org yurys at chromium.org
Sun Feb 20 23:43:24 UTC 2011


The following commit has been merged in the webkit-1.3 branch:
commit 2e3a4c1a0087b59506630703221228b9da536ed8
Author: yurys at chromium.org <yurys at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Jan 24 15:20:30 2011 +0000

    2011-01-24  Yury Semikhatsky  <yurys at chromium.org>
    
            Reviewed by Pavel Feldman.
    
            Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
            https://bugs.webkit.org/show_bug.cgi?id=53007
    
            It's impossible to create "provisional" inspector for pages which are
            not yet created so there is no need to listen for page creation in ScriptDebugServer.
    
            * bindings/js/ScriptDebugServer.cpp:
            * bindings/js/ScriptDebugServer.h:
            * page/Page.cpp:
            (WebCore::Page::Page):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 1231f03..3686e14 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2011-01-24  Yury Semikhatsky  <yurys at chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
+        https://bugs.webkit.org/show_bug.cgi?id=53007
+
+        It's impossible to create "provisional" inspector for pages which are
+        not yet created so there is no need to listen for page creation in ScriptDebugServer.
+
+        * bindings/js/ScriptDebugServer.cpp:
+        * bindings/js/ScriptDebugServer.h:
+        * page/Page.cpp:
+        (WebCore::Page::Page):
+
 2011-01-24  Pavel Podivilov  <podivilov at chromium.org>
 
         Reviewed by Pavel Feldman.
diff --git a/Source/WebCore/bindings/js/ScriptDebugServer.cpp b/Source/WebCore/bindings/js/ScriptDebugServer.cpp
index c3a3fa8..33a318c 100644
--- a/Source/WebCore/bindings/js/ScriptDebugServer.cpp
+++ b/Source/WebCore/bindings/js/ScriptDebugServer.cpp
@@ -117,15 +117,6 @@ void ScriptDebugServer::removeListener(ScriptDebugListener* listener, Page* page
     didRemoveListener(page);
 }
 
-void ScriptDebugServer::pageCreated(Page* page)
-{
-    ASSERT_ARG(page, page);
-
-    if (!hasListenersInterestedInPage(page))
-        return;
-    page->setDebugger(this);
-}
-
 bool ScriptDebugServer::isDebuggerAlwaysEnabled()
 {
     return false;
diff --git a/Source/WebCore/bindings/js/ScriptDebugServer.h b/Source/WebCore/bindings/js/ScriptDebugServer.h
index c0b44c7..1e38819 100644
--- a/Source/WebCore/bindings/js/ScriptDebugServer.h
+++ b/Source/WebCore/bindings/js/ScriptDebugServer.h
@@ -93,8 +93,6 @@ public:
 
     JavaScriptCallFrame* currentCallFrame();
 
-    void pageCreated(Page*);
-
     bool isDebuggerAlwaysEnabled();
 
 private:
diff --git a/Source/WebCore/page/Page.cpp b/Source/WebCore/page/Page.cpp
index 012a9be..8550681 100644
--- a/Source/WebCore/page/Page.cpp
+++ b/Source/WebCore/page/Page.cpp
@@ -83,10 +83,6 @@
 #include "StorageNamespace.h"
 #endif
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-#include "ScriptDebugServer.h"
-#endif
-
 #if ENABLE(WML)
 #include "WMLPageState.h"
 #endif
@@ -180,10 +176,6 @@ Page::Page(const PageClients& pageClients)
         m_pluginHalter->setPluginAllowedRunTime(m_settings->pluginAllowedRunTime());
     }
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-    ScriptDebugServer::shared().pageCreated(this);
-#endif
-
 #ifndef NDEBUG
     pageCounter.increment();
 #endif

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list