[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198
rwlbuis at webkit.org
rwlbuis at webkit.org
Mon Feb 21 00:02:55 UTC 2011
The following commit has been merged in the webkit-1.3 branch:
commit 8cc11e6d2bdc2715dd9a866ffaf3dbaa7d83b581
Author: rwlbuis at webkit.org <rwlbuis at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Jan 27 20:02:36 2011 +0000
2011-01-27 Rob Buis <rwlbuis at gmail.com>
Reviewed by Kent Tamura.
Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790
Redirect style changes on <option> element to the owner <select> element.
Test: fast/repaint/select-option-background-color.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setRenderStyle):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index a4a8e12..bc3ca26 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2011-01-27 Rob Buis <rwlbuis at gmail.com>
+
+ Reviewed by Kent Tamura.
+
+ Add test for:
+ Color changes to option elements in a select multiple aren't drawn immediately
+ https://bugs.webkit.org/show_bug.cgi?id=49790
+
+ * fast/repaint/select-option-background-color.html: Added.
+ * platform/mac/fast/repaint/select-option-background-color-expected.checksum: Added.
+ * platform/mac/fast/repaint/select-option-background-color-expected.png: Added.
+ * platform/mac/fast/repaint/select-option-background-color-expected.txt: Added.
+
2011-01-27 David Grogan <dgrogan at google.com>
Reviewed by Jeremy Orlow.
diff --git a/LayoutTests/fast/repaint/select-option-background-color.html b/LayoutTests/fast/repaint/select-option-background-color.html
new file mode 100644
index 0000000..804f79d
--- /dev/null
+++ b/LayoutTests/fast/repaint/select-option-background-color.html
@@ -0,0 +1,21 @@
+<head>
+<title>This is a test for regression against https://bugs.webkit.org/show_bug.cgi?id=49790</title>
+</head>
+
+<body style="margin: 0;" onload="runRepaintTest()">
+ <script>
+ function repaintTest()
+ {
+ document.getElementById('option').style.backgroundColor = 'green';
+ }
+ </script>
+
+ <script src="resources/repaint.js"></script>
+
+ <p>This is a test for regression against <a href="https://bugs.webkit.org/show_bug.cgi?id=49790">https://bugs.webkit.org/show_bug.cgi?id=49790</a></p>
+
+ <select multiple="multiple">
+ <option id="option" value="A">A</option>
+ <option id="option" value="B">B</option>
+ </select>
+</body>
diff --git a/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.checksum b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.checksum
new file mode 100644
index 0000000..e8b04c5
--- /dev/null
+++ b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.checksum
@@ -0,0 +1 @@
+29bae32726dbba8b202adb59b33e7947
\ No newline at end of file
diff --git a/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.png b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.png
new file mode 100644
index 0000000..40fdc50
Binary files /dev/null and b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.png differ
diff --git a/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.txt b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.txt
new file mode 100644
index 0000000..2794e78
--- /dev/null
+++ b/LayoutTests/platform/mac/fast/repaint/select-option-background-color-expected.txt
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (0,0) size 800x600
+ RenderBlock {P} at (0,0) size 800x18
+ RenderText {#text} at (0,0) size 220x18
+ text run at (0,0) width 220: "This is a test for regression against "
+ RenderInline {A} at (0,0) size 305x18 [color=#0000EE]
+ RenderText {#text} at (220,0) size 305x18
+ text run at (220,0) width 305: "https://bugs.webkit.org/show_bug.cgi?id=49790"
+ RenderBlock (anonymous) at (0,34) size 800x61
+ RenderListBox {SELECT} at (2,2) size 25x57 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
+ RenderText {#text} at (0,0) size 0x0
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 3eeb31e..3c9a78c 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2011-01-27 Rob Buis <rwlbuis at gmail.com>
+
+ Reviewed by Kent Tamura.
+
+ Color changes to option elements in a select multiple aren't drawn immediately
+ https://bugs.webkit.org/show_bug.cgi?id=49790
+
+ Redirect style changes on <option> element to the owner <select> element.
+
+ Test: fast/repaint/select-option-background-color.html
+
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::setRenderStyle):
+
2011-01-19 Stephen White <senorblanco at chromium.org>
Reviewed by Darin Adler.
diff --git a/Source/WebCore/html/HTMLOptionElement.cpp b/Source/WebCore/html/HTMLOptionElement.cpp
index e8f624c..bc5788d 100644
--- a/Source/WebCore/html/HTMLOptionElement.cpp
+++ b/Source/WebCore/html/HTMLOptionElement.cpp
@@ -221,6 +221,9 @@ String HTMLOptionElement::label() const
void HTMLOptionElement::setRenderStyle(PassRefPtr<RenderStyle> newStyle)
{
m_style = newStyle;
+ if (HTMLSelectElement* select = ownerSelectElement())
+ if (RenderObject* renderer = select->renderer())
+ renderer->repaint();
}
RenderStyle* HTMLOptionElement::nonRendererRenderStyle() const
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list