[SCM] WebKit Debian packaging branch, webkit-1.3, updated. upstream/1.3.7-4207-g178b198
ojan at chromium.org
ojan at chromium.org
Mon Feb 21 00:36:59 UTC 2011
The following commit has been merged in the webkit-1.3 branch:
commit 85ea888eaf0d95c708cc355736a0768efa2a4aa1
Author: ojan at chromium.org <ojan at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed Feb 2 05:17:38 2011 +0000
2011-02-01 Ojan Vafai <ojan at chromium.org>
Reviewed by Adam Barth.
avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 9f01a70..6dc492f 100644
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,5 +1,14 @@
2011-02-01 Ojan Vafai <ojan at chromium.org>
+ Reviewed by Adam Barth.
+
+ avoid jitter when loading the comments to a patch
+ https://bugs.webkit.org/show_bug.cgi?id=53570
+
+ * code-review.js:
+
+2011-02-01 Ojan Vafai <ojan at chromium.org>
+
Reviewed by Mihai Parparita.
[codereviewtool] extra space at the beginning of lines in side-by-side view
diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index 553dded..ba10936 100644
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -417,7 +417,7 @@ body {
}
</style>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
-<script src="code-review.js?version=31"></script>
+<script src="code-review.js?version=32"></script>
EOF
def self.revisionOrDescription(string)
diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index d626d3a..f5f4b44 100644
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -374,16 +374,14 @@ var CODE_REVIEW_UNITTEST;
});
}
- var help_text = 'Scroll though diffs with the "j" and "k" keys.';
if (comments.length == 0) {
- $('#message .commentStatus').text(help_text);
return;
}
descriptor = comments.length + ' comment';
if (comments.length > 1)
descriptor += 's';
- $('#message .commentStatus').text('This patch has ' + descriptor + '. Scroll through them with the "n" and "p" keys. ' + help_text);
+ $('.help').append(' This patch has ' + descriptor + '. Scroll through them with the "n" and "p" keys.');
}
function scanForStyleQueueComments(text) {
@@ -997,10 +995,9 @@ var CODE_REVIEW_UNITTEST;
crawlDiff();
fetchHistory();
$(document.body).prepend('<div id="message">' +
- '<div class="help">Select line numbers to add a comment.' +
+ '<div class="help">Select line numbers to add a comment. Scroll though diffs with the "j" and "k" keys.' +
'<div class="DiffLinks LinkContainer">' + diffLinksHtml() + '</div>' +
'</div>' +
- '<div class="commentStatus"></div>' +
'</div>');
$(document.body).append('<div id="toolbar">' +
'<div class="overallComments">' +
--
WebKit Debian packaging
More information about the Pkg-webkit-commits
mailing list