[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-1049-g2e11a8e

loislo at chromium.org loislo at chromium.org
Fri Jan 21 14:37:20 UTC 2011


The following commit has been merged in the debian/experimental branch:
commit f2509de90581d00f2653e6a26fc1df21b598616e
Author: loislo at chromium.org <loislo at chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Dec 23 09:20:42 2010 +0000

    2010-12-23  Ilya Tikhonovsky  <loislo at chromium.org>
    
            Reviewed by Eric Seidel.
    
            Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
    
            Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
            I just discovered that we have two additional GC runs per each WebViewHost.
            Test_shell had no such calls.
            These gc runs eat 15% of cpu time.
    
            https://bugs.webkit.org/show_bug.cgi?id=51479
    
            * DumpRenderTree/chromium/WebViewHost.cpp:
            (WebViewHost::~WebViewHost):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 65aaa70..a59313c 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,19 @@
+2010-12-23  Ilya Tikhonovsky  <loislo at chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
+
+        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
+        I just discovered that we have two additional GC runs per each WebViewHost.
+        Test_shell had no such calls.
+        These gc runs eat 15% of cpu time.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51479
+
+        * DumpRenderTree/chromium/WebViewHost.cpp:
+        (WebViewHost::~WebViewHost):
+
 2010-12-22  Dirk Pranke  <dpranke at chromium.org>
 
         Reviewed by Ojan Vafai.
diff --git a/Tools/DumpRenderTree/chromium/WebViewHost.cpp b/Tools/DumpRenderTree/chromium/WebViewHost.cpp
index e3c8c28..d880879 100644
--- a/Tools/DumpRenderTree/chromium/WebViewHost.cpp
+++ b/Tools/DumpRenderTree/chromium/WebViewHost.cpp
@@ -1133,10 +1133,6 @@ WebViewHost::~WebViewHost()
         loadURLForFrame(GURL("about:blank"), WebString());
     }
 
-    // Call GC twice to clean up garbage.
-    m_shell->callJSGC();
-    m_shell->callJSGC();
-
     webWidget()->close();
 
     if (m_inModalLoop)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list