[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-1049-g2e11a8e

andersca at apple.com andersca at apple.com
Fri Jan 21 14:38:22 UTC 2011


The following commit has been merged in the debian/experimental branch:
commit 4bc6a6556181bc16ce17f74875f915b1d23ac4cd
Author: andersca at apple.com <andersca at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Dec 23 19:33:41 2010 +0000

    2010-12-23  Anders Carlsson  <andersca at apple.com>
    
            Reviewed by Sam Weinig.
    
            New popup windows open disproportionately big
            https://bugs.webkit.org/show_bug.cgi?id=51547
            <rdar://problem/8637029>
    
            * UIProcess/WebPageProxy.cpp:
            (WebKit::WebPageProxy::createNewPage):
            Pass the correct size back to the UI process.
    
            * WebProcess/WebCoreSupport/WebChromeClient.cpp:
            (WebKit::WebChromeClient::pageRect):
            Implement this and return the size of the page.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit2/ChangeLog b/WebKit2/ChangeLog
index 3db8723..5fb9677 100644
--- a/WebKit2/ChangeLog
+++ b/WebKit2/ChangeLog
@@ -1,5 +1,21 @@
 2010-12-23  Anders Carlsson  <andersca at apple.com>
 
+        Reviewed by Sam Weinig.
+
+        New popup windows open disproportionately big
+        https://bugs.webkit.org/show_bug.cgi?id=51547
+        <rdar://problem/8637029>
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::createNewPage):
+        Pass the correct size back to the UI process.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::pageRect):
+        Implement this and return the size of the page.
+
+2010-12-23  Anders Carlsson  <andersca at apple.com>
+
         Reviewed by John Sullivan.
 
         Nothing happens clicking "launch live player" on live.cnn.com
diff --git a/WebKit2/UIProcess/WebPageProxy.cpp b/WebKit2/UIProcess/WebPageProxy.cpp
index 81f2f36..6f780d5 100644
--- a/WebKit2/UIProcess/WebPageProxy.cpp
+++ b/WebKit2/UIProcess/WebPageProxy.cpp
@@ -1288,9 +1288,8 @@ void WebPageProxy::createNewPage(const WindowFeatures& windowFeatures, uint32_t
 {
     RefPtr<WebPageProxy> newPage = m_uiClient.createNewPage(this, windowFeatures, static_cast<WebEvent::Modifiers>(opaqueModifiers), static_cast<WebMouseEvent::Button>(opaqueMouseButton));
     if (newPage) {
-        // FIXME: Pass the real size.
         newPageID = newPage->pageID();
-        newPageParameters = newPage->creationParameters(IntSize(100, 100));
+        newPageParameters = newPage->creationParameters(newPage->drawingArea()->size());
     } else
         newPageID = 0;
 }
diff --git a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
index 7446ff7..2dec462 100644
--- a/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
+++ b/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
@@ -81,8 +81,7 @@ FloatRect WebChromeClient::windowRect()
 
 FloatRect WebChromeClient::pageRect()
 {
-    notImplemented();
-    return FloatRect();
+    return FloatRect(FloatPoint(), m_page->size());
 }
 
 float WebChromeClient::scaleFactor()

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list