[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-1049-g2e11a8e

mrobinson at webkit.org mrobinson at webkit.org
Fri Jan 21 14:43:41 UTC 2011


The following commit has been merged in the debian/experimental branch:
commit f91520f0e4b666bf811e1f307f50171ee85df1b5
Author: mrobinson at webkit.org <mrobinson at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Dec 27 22:37:15 2010 +0000

    2010-12-27  Martin Robinson  <mrobinson at igalia.com>
    
            Reviewed by Daniel Bates.
    
            [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
            https://bugs.webkit.org/show_bug.cgi?id=51654
    
            Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
            on some debug configurations.
    
            No new tests. This is already covered by current slider tests. It isn't crashing on
            the bots, but it does crash locally.
    
            * platform/gtk/RenderThemeGtk.cpp:
            (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 9a250a5..a05ddd0 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2010-12-27  Martin Robinson  <mrobinson at igalia.com>
+
+        Reviewed by Daniel Bates.
+
+        [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
+        https://bugs.webkit.org/show_bug.cgi?id=51654
+
+        Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
+        on some debug configurations.
+
+        No new tests. This is already covered by current slider tests. It isn't crashing on
+        the bots, but it does crash locally.
+
+        * platform/gtk/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
+
 2010-12-27  Anton Muhin  <antonm at chromium.org>
 
         Reviewed by David Levin.
diff --git a/WebCore/platform/gtk/RenderThemeGtk.cpp b/WebCore/platform/gtk/RenderThemeGtk.cpp
index d34847d..d92c505 100644
--- a/WebCore/platform/gtk/RenderThemeGtk.cpp
+++ b/WebCore/platform/gtk/RenderThemeGtk.cpp
@@ -141,6 +141,8 @@ RenderThemeGtk::RenderThemeGtk()
     , m_gtkButton(0)
     , m_gtkEntry(0)
     , m_gtkTreeView(0)
+    , m_gtkVScale(0)
+    , m_gtkHScale(0)
     , m_panelColor(Color::white)
     , m_sliderColor(Color::white)
     , m_sliderThumbColor(Color::white)

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list