[SCM] WebKit Debian packaging branch, debian/experimental, updated. debian/1.3.8-1-1049-g2e11a8e

commit-queue at webkit.org commit-queue at webkit.org
Fri Jan 21 15:00:02 UTC 2011


The following commit has been merged in the debian/experimental branch:
commit 6601cf399c43b678a8769f921edbdd91f82a9f98
Author: commit-queue at webkit.org <commit-queue at webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jan 6 04:09:23 2011 +0000

    2011-01-05  Jeff Miller  <jeffm at apple.com>
    
            Reviewed by Adam Roben.
    
            check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
            https://bugs.webkit.org/show_bug.cgi?id=51970
    
            * Scripts/webkitpy/style/checker.py:
            Add -readability/naming for WebKit2 C API directories.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index d094991..9bd9ab1 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,13 @@
+2011-01-05  Jeff Miller  <jeffm at apple.com>
+
+        Reviewed by Adam Roben.
+
+        check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
+        https://bugs.webkit.org/show_bug.cgi?id=51970
+
+        * Scripts/webkitpy/style/checker.py:
+        Add -readability/naming for WebKit2 C API directories.
+
 2011-01-05  Eric Seidel  <eric at webkit.org>
 
         Unreviewed, just fixing one more log error from my previous python patch.
diff --git a/Tools/Scripts/webkitpy/style/checker.py b/Tools/Scripts/webkitpy/style/checker.py
index 20758ba..bec8bd4 100644
--- a/Tools/Scripts/webkitpy/style/checker.py
+++ b/Tools/Scripts/webkitpy/style/checker.py
@@ -169,11 +169,13 @@ _PATH_RULES_SPECIFIER = [
      ["-build/include_order",
       "-readability/naming"]),
     ([# The WebKit2 C API has names with underscores and whitespace-aligned
-      # struct members.
+      # struct members. Also, we allow unnecessary parameter names in
+      # WebKit2 APIs because we're matching CF's header style.
       "WebKit2/UIProcess/API/C/",
       "WebKit2/WebProcess/InjectedBundle/API/c/"],
      ["-build/include_order",
       "-readability/naming",
+      "-readability/parameter_name",
       "-whitespace/declaration"]),
     ([# Nothing in WebKit2 uses config.h.
       "WebKit2/"],

-- 
WebKit Debian packaging



More information about the Pkg-webkit-commits mailing list