[pkg-wine-party] Bug#658958: Bug#658958: wineconsole: please use curses backend when DISPLAY is not set

[Austin English]

On Wed, Oct 3, 2012 at 6:27 AM, Bill Allombert
<Bill.Allombert at math.u-bordeaux1.fr> wrote:
> On Thu, Sep 13, 2012 at 11:14:05AM -0700, Austin English wrote:
>> On Mon, Sep 10, 2012 at 5:36 PM, Austin English <austinenglish at gmail.com> wrote:
>> > forwarded 658958 http://bugs.winehq.org/show_bug.cgi?id=31670
>>
>> fixed 658958 1.4.1-2
>
> Indeed this version fix the problem, but there no mention in the changelog.
> What was the issue ?

It was fixed by:
commit 359cd00982e86d899bbdb5a14a69a398de646c3c
Author: Kirill K. Smirnov <lich at math.spbu.ru>
Date:   Sat Aug 2 21:03:05 2008 +0400

    wineconsole: Check return value of CreateWindow() for errors, do
not rely upon callback function.

diff --git a/programs/wineconsole/user.c b/programs/wineconsole/user.c
index 6ded183..03157aa 100644
--- a/programs/wineconsole/user.c
+++ b/programs/wineconsole/user.c
@@ -1434,7 +1434,7 @@ enum init_return WCUSER_InitBackend(struct
inner_data* data)

     RegisterClass(&wndclass);

-    CreateWindow(wndclass.lpszClassName, NULL,
+    data->hWnd = CreateWindow(wndclass.lpszClassName, NULL,

WS_OVERLAPPED|WS_CAPTION|WS_SYSMENU|WS_THICKFRAME|WS_MINIMIZEBOX|WS_HSCROLL|WS_VSCROLL,
                 CW_USEDEFAULT, CW_USEDEFAULT, 0, 0, 0, 0,
wndclass.hInstance, data);
     if (!data->hWnd) return init_not_supported;

essentially Wine wasn't checking if the windows creation succeeded.
After this commit it does, then falls back to curses.

The first version with the fix was wine-1.1.3.

-- 
-Austin