[pkg-wine-party] Bug#733605: Bug#733605: [PATCH] Add support for GNU/Hurd
svante.signell at gmail.com
Fri Jan 3 15:52:51 UTC 2014
On Fri, 2014-01-03 at 10:18 -0500, Michael Gilbert wrote:
> On Fri, Jan 3, 2014 at 6:32 AM, Svante Signell wrote:
> > - dlls/ntdll/directory.c: Define a character array on the heap of size
> > 4096 instead of using PATH_MAX, which is not defined for GNU/Hurd. This
> > approach was used in dlls/ntdll/file.c:server_get_unix_name() where an
> > array of size 1024 was defined. In case this solution is not OK, a fixed
> > size array on the stack could be used, or as a last resort adding
> > #ifndef PATH_MAX; #define PATH_MAX 4096 to that file (not recommended,
> > at least from a GNU/Hurd aspect).
> This version of the patch still hard-codes data_size. The Debian hurd
> porting guide requires paths to be dynamically allocated.
>From the reply by André Hentschel:
> I recently sent a patch for this and failed, problem is that you can't
> allocate memory inside an APC callback.
> I think we should address this first before the other issues.
Additionally, the code mentioned in dlls/ntdll/file.c also use a
hardcoded array size.
More information about the pkg-wine-party