[pkg-wine-party] disable/shlib-exit-calls.patch

[Jens Reyer]

Hi all,

I unsuccessfully tried to get disable/shlib-exit-calls.patch applied
upstream, but in the end it was rejected. See the "Don't call exit in
the shared library." threads (v3 and v4) in wine-patches/wine-devel this
month.

There were some specific comments for single changes, but more
importantly this:

On 11.10.2016 16:59, Sebastian Lackner wrote:
> I'm not sure if this is really a good idea. In contrast to exit, abort() might
> trigger the creation of a core dump. Unfortunately fatal_[p]error is also used
> at many places as a shortcut for "fprintf(stderr,...); exit(1)". This means after
> this change, a lot of users might see "Aborted (core dumped)" even for harmless
> error messages.
> [...]
> Before changing things in Winelib, it would first be necessary to modify all
> involved tools and dlls to avoid fatal_[p]error for harmless errors.

And finally:

On 12.10.2016 14:52, Alexandre Julliard wrote:
> I don't think that's a useful goal. It's not a bad idea to review its
> usage, and possibly replace it where it makes sense, but there are
> also places where exit is needed.

I don't expect anyone working on this (but would love to be proven
wrong). Therefore I suggest to drop this patch and add a lintian
override explaining the situation.

Greets
jre