[pkg-wine-party] Bug#836566: Fix committed for #836566 and probably #836566

Jens Reyer jre.winesim at gmail.com
Tue Sep 13 20:47:52 UTC 2016


control: tag -1 + pending

On 13.09.2016 21:18, Jens Reyer wrote:
> jreyer-guest pushed a commit to branch master
> in repository wine.
> 
> commit 8103285d2870713930df7004a2afa292902461af
> Author: Jens Reyer <jre.winesim at gmail.com>
> Date:   Tue Sep 13 21:17:02 2016 +0200
> 
>     Generate the correct SERVER_PROTOCOL_VERSION.
>     
>     Closes: #836911
>     Closes in stable: #836566
>     
>     SERVER_PROTOCOL_VERSION is used to check if the running server's
>     and the client's version match. It is set in
>     include/wine/server_protocol.h (currently 515), and increased by
>     1 by make_requests. But we clean server_protocol.h because it is
>     generated, so SERVER_PROTOCOL_VERSION in Debian is always 1.
>     
>     To fix this retrieve SERVER_PROTOCOL_VERSION on upstream import
>     before server_protocol.h is cleaned, and store it (decreased by
>     1) in request.patch. make_request will then regenerate
>     server_protocol.h with the correct SERVER_PROTOCOL_VERSION.

I'm quite sure #836566 (src:wine-development) will be fixed by this.

For #836566 (src:wine) I only assume so. If I'm right the issue in
src:wine will be fixed by the new wine-development, because version
mismatches will then be detected like this:

$ wine --version
wine-1.8.4 (Debian 1.8.4-1)
$ wine-development --version
wine-1.9.18 (Debian 1.9.18-2~local1)
$ winecfg &
$ winecfg-development
wine client error:0: version mismatch 1/515.
Your wineserver binary was not upgraded correctly,
or you have an older one somewhere in your PATH.
Or maybe the wrong wineserver is still running?

However Erik's answer in
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836566#20
might indicate that I'm on the wrong trail here. Unfortunately I got no
answer for my followup question yet.

Better ways to solve this are welcome.

jre



More information about the pkg-wine-party mailing list