[pkg-wine-party] Request for comment on a possible 0.10.0 release for gnome-exe-thumbnailer

[James Lu]

Hi Scott and Jan,

In case you haven't heard, I recently tagged+released
gnome-exe-thumbnailer 0.9.5[1] in order to fix CVE-2017-11421[2]. Since
then, I've committed several other code updates to the master branch,
which I eventually plan to release as 0.10.x. The full diff so far is
here:
https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/compare/0.9.5...master

I won't go and mention every change in the mail because I hope my commit
messages are straightforward enough. However, some of the more major
changes are:

1) Switching to $XDG_CACHE_HOME for thumbnails, per
https://bugs.launchpad.net/ubuntu/+source/gnome-exe-thumbnailer/+bug/1105796.
I didn't include any migration code away from the old path because I
believe that the thumbnails can just be regenerated at the new path (but
correct me if I'm wrong here!).

2) Minor security fix: replace insecure /tmp usage (suffixed files) with
a temporary directory, per
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868737.

3) Supporting icon theme fetching on MATE, Xfce, and Cinnamon - the file
managers used in these DEs all support desktop thumbnailers now, so
gnome-exe-thumbnailer isn't exactly gnome-specific anymore.

4) Replacing .lnk parsing with liblnk's lnkinfo, and adding support for
relative paths. One of my eventual goals is to replace g-e-t's
dependency on wine entirely (this removes half of the calls), as it is
large and not always the fastest solution.[3]
    - However, .lnk thumbnailing is still quite broken, because many
Windows shortcuts (especially ones that link to a different partition)
use absolute paths. These links are broken 90% of the time because the
partition mapping in ~/.wine/dosdevices/ rarely ends up matching a
Windows configuration without prior configuration. Unfortunately, I
don't see a great alternative here[4].

5) Fixing numerous shellcheck warnings by cleaning up the code.

6) Merging in a new Moka template from Alfredo Hernández:
https://bugs.launchpad.net/ubuntu/+source/gnome-exe-thumbnailer/+bug/1404744

As always, comments and feedback are very much appreciated!

Best,
James

[1]:
https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/compare/0.9.4...0.9.5
[2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11421
[3]: https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/issues/7
[4]: https://github.com/gnome-exe-thumbnailer/gnome-exe-thumbnailer/issues/6

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-wine-party/attachments/20170804/ceb0e54a/attachment.sig>