[pkg-wine-party] [wine] 45/50: Blacklist some extensions for native file type association.

[Jens Reyer]

This is an automated email from the git hooks/post-receive script.

jreyer-guest pushed a commit to branch master
in repository wine.

commit bdda469b2718e561dced33c0c9b3089e2fb24b2a
Author: Jens Reyer <jre.winesim at gmail.com>
Date:   Sun Jan 8 13:56:42 2017 +0100

    Blacklist some extensions for native file type association.
    
    See: #845334
---
 debian/changelog                                   |  3 +-
 .../winemenubuilder-blacklist-extensions.patch     | 60 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 3 files changed, 63 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 98fa29d..0bc4737 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,7 @@
 wine-development (2.0~rc3-2) UNRELEASED; urgency=medium
 
-  * Don't create native file type associations automatically.
+  * Blacklist some file extensions for native file type association
+    (see: #845334).
 
  -- Jens Reyer <jre.winesim at gmail.com>  Thu, 05 Jan 2017 16:58:25 +0100
 
diff --git a/debian/patches/disable/winemenubuilder-blacklist-extensions.patch b/debian/patches/disable/winemenubuilder-blacklist-extensions.patch
new file mode 100644
index 0000000..d38277b
--- /dev/null
+++ b/debian/patches/disable/winemenubuilder-blacklist-extensions.patch
@@ -0,0 +1,60 @@
+Description: Blacklist all extensions that trigger a freedesktop file type association from an empty prefix.
+Author: Jens Reyer <jre.winesim at gmail.com>
+Bug: https://bugs.winehq.org/show_bug.cgi?id=28159
+Bug-Debian: https://bugs.debian.org/845334
+
+--- a/programs/winemenubuilder/winemenubuilder.c
++++ b/programs/winemenubuilder/winemenubuilder.c
+@@ -2465,10 +2465,51 @@ static BOOL is_extension_blacklisted(LPC
+     static const WCHAR comW[] = {'.','c','o','m',0};
+     static const WCHAR exeW[] = {'.','e','x','e',0};
+     static const WCHAR msiW[] = {'.','m','s','i',0};
++    /* All extensions that are associated natively from an empty prefix. Blacklist them for security
++     * reasons, and because most people don't want their native file type associations changed.
++     */
++    static const WCHAR chmW[] = {'.','c','h','m',0};
++    static const WCHAR gifW[] = {'.','g','i','f',0};
++    static const WCHAR hlpW[] = {'.','h','l','p',0};
++    static const WCHAR htmW[] = {'.','h','t','m',0};
++    static const WCHAR htmlW[] = {'.','h','t','m','l',0};
++    static const WCHAR iniW[] = {'.','i','n','i',0};
++    static const WCHAR jfifW[] = {'.','j','f','i','f',0};
++    static const WCHAR jpeW[] = {'.','j','p','e',0};
++    static const WCHAR jpegW[] = {'.','j','p','e','g',0};
++    static const WCHAR jpgW[] = {'.','j','p','g',0};
++    static const WCHAR mspW[] = {'.','m','s','p',0};
++    static const WCHAR pdfW[] = {'.','p','d','f',0};
++    static const WCHAR pngW[] = {'.','p','n','g',0};
++    static const WCHAR rtfW[] = {'.','r','t','f',0};
++    static const WCHAR txtW[] = {'.','t','x','t',0};
++    static const WCHAR urlW[] = {'.','u','r','l',0};
++    static const WCHAR vbsW[] = {'.','v','b','s',0};
++    static const WCHAR wriW[] = {'.','w','r','i',0};
++    static const WCHAR xmlW[] = {'.','x','m','l',0};
+ 
+     if (!strcmpiW(extension, comW) ||
+         !strcmpiW(extension, exeW) ||
+-        !strcmpiW(extension, msiW))
++        !strcmpiW(extension, msiW) ||
++        !strcmpiW(extension, chmW) ||
++        !strcmpiW(extension, gifW) ||
++        !strcmpiW(extension, hlpW) ||
++        !strcmpiW(extension, htmW) ||
++        !strcmpiW(extension, htmlW) ||
++        !strcmpiW(extension, iniW) ||
++        !strcmpiW(extension, jfifW) ||
++        !strcmpiW(extension, jpeW) ||
++        !strcmpiW(extension, jpegW) ||
++        !strcmpiW(extension, jpgW) ||
++        !strcmpiW(extension, mspW) ||
++        !strcmpiW(extension, pdfW) ||
++        !strcmpiW(extension, pngW) ||
++        !strcmpiW(extension, rtfW) ||
++        !strcmpiW(extension, txtW) ||
++        !strcmpiW(extension, urlW) ||
++        !strcmpiW(extension, vbsW) ||
++        !strcmpiW(extension, wriW) ||
++        !strcmpiW(extension, xmlW))
+         return TRUE;
+     return FALSE;
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 65c24be..a81fdaa 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,6 +4,7 @@ manpages-wineserver-persistence.patch
 disable/tests.patch
 disable/addons-download.patch
 disable/rerun-configure.patch
+disable/winemenubuilder-blacklist-extensions.patch
 
 generate/fonts.patch
 generate/opengl.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-wine/wine.git