[Pkg-wmaker-commits] [wmforecast] 35/63: check return value of mkdir (Coverity 65085)

[Doug Torrance]

This is an automated email from the git hooks/post-receive script.

dtorrance-guest pushed a commit to branch master
in repository wmforecast.

commit 7ea276fb4db0aae0738aee8bfb01124be5614f33
Author: Doug Torrance <dtorrance at monmouthcollege.edu>
Date:   Fri May 30 23:20:07 2014 -0600

    check return value of mkdir (Coverity 65085)
---
 ChangeLog    |  2 ++
 wmforecast.c | 11 ++++++++---
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e2c2ee7..335a735 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,8 @@
 2014-05-30  Doug Torrance <dtorrance at monmouthcollege.edu>
 	* wmforecast.c (getWeather): fix missing return statements (Coverity
 	  65086)
+	* wmforecast.c (savePreferences): check return value of mkdir (Coverity
+	  65085)
 
 2014-05-11  Doug Torrance <dtorrance at monmouthcollege.edu>
 	* Makefile.am: use dist_man_MANS instead of adding man_MANS to EXTRA_DIST
diff --git a/wmforecast.c b/wmforecast.c
index 648469c..a609e06 100755
--- a/wmforecast.c
+++ b/wmforecast.c
@@ -20,6 +20,7 @@
 #endif
 
 #include <curl/curl.h>
+#include <errno.h>
 #include <getopt.h>
 #include <libgen.h>
 #include <libxml/tree.h>
@@ -690,6 +691,7 @@ static void savePreferences(WMWidget *widget, void *data)
 	char *prefsString;
 	Dockapp *d = (Dockapp *)data;
 	FILE *file;
+	int md;
 	WMPropList *prefsPL;
 	WMPropList *key;
 	WMPropList *object;
@@ -733,12 +735,15 @@ static void savePreferences(WMWidget *widget, void *data)
 	prefsString = WMGetPropListDescription(prefsPL, True);
 
 	dir = getPreferencesDirectory();
-	mkdir(dir, 0777);
+	md = mkdir(dir, 0777);
+	if (md < 0) {
+		printf("Error making directory %s: %s\n", dir,
+		       strerror(errno));
+	}
 
 	filename = getPreferencesFilename();
 	file = fopen(filename, "w");
-	if (file)
-	{
+	if (file) {
 		fputs(prefsString, file);
 		fclose(file);
 	}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-wmaker/wmforecast.git