[Pkg-wmaker-commits] [wmbiff] 14/92: wmbiff: Fix memory leaks pointed out by valgrind.
Doug Torrance
dtorrance-guest at moszumanska.debian.org
Thu Aug 20 02:59:20 UTC 2015
This is an automated email from the git hooks/post-receive script.
dtorrance-guest pushed a commit to branch master
in repository wmbiff.
commit e0c533c3c8f1bd7d9381194659f216ad0f05f988
Author: Gabriel VLASIU <gabriel at vlasiu.net>
Date: Thu Apr 4 13:56:46 2013 +0300
wmbiff: Fix memory leaks pointed out by valgrind.
---
wmbiff/wmbiff.c | 6 ++++++
wmgeneral/wmgeneral.c | 9 +++++++++
2 files changed, 15 insertions(+)
diff --git a/wmbiff/wmbiff.c b/wmbiff/wmbiff.c
index 35b1fa8..b9d216d 100644
--- a/wmbiff/wmbiff.c
+++ b/wmbiff/wmbiff.c
@@ -1168,6 +1168,12 @@ static void do_biff(int argc, const char **argv)
free(skin_xpm); // added 3 jul 02, appeasing valgrind
}
if (bkg_xpm != NULL) {
+ // Allocated in CreateBackingXPM()
+ free((void *)bkg_xpm[0]);
+ free((void *)bkg_xpm[2]);
+ int mem_block;
+ for (mem_block = 6; mem_block < 6 + wmbiff_mask_height; mem_block++)
+ free((void *)bkg_xpm[mem_block]);
free(bkg_xpm);
}
}
diff --git a/wmgeneral/wmgeneral.c b/wmgeneral/wmgeneral.c
index 88d76fe..cb0fd6d 100644
--- a/wmgeneral/wmgeneral.c
+++ b/wmgeneral/wmgeneral.c
@@ -469,6 +469,11 @@ void openXwindow(int argc, const char *argv[],
int dummy = 0;
int i;
+ if (!wname) {
+ fprintf(stderr, "Unable to allocate memory for window name!\n");
+ abort();
+ }
+
for (i = 1; argv[i]; i++) {
if (!strcmp(argv[i], "-display")) {
display_name = argv[i + 1];
@@ -543,6 +548,7 @@ void openXwindow(int argc, const char *argv[],
}
XSetWMName(display, win, &name);
+ XFree(name.value);
/* Create GC for drawing */
@@ -609,4 +615,7 @@ void openXwindow(int argc, const char *argv[],
exit(1);
} */
}
+
+ if (wname)
+ free(wname);
}
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-wmaker/wmbiff.git
More information about the Pkg-wmaker-commits
mailing list