[Pkg-wmaker-commits] [wmcoincoin] 55/87: inconsistent order of #include causes incompatible struct types

[Doug Torrance]

This is an automated email from the git hooks/post-receive script.

dtorrance-guest pushed a commit to branch master
in repository wmcoincoin.

commit cf72acda99df925e268a82986448c657ed7758d3
Author: Michael Tautschnig <mt at debian.org>
Date:   Tue Nov 11 12:13:53 2014 -0600

    inconsistent order of #include causes incompatible struct types
    
    From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702439:
    
    While building the package using our research compiler infrastructure we noticed
    incompatible types of struct re_pattern_buffer (from regex.h) being used within
    the declaration of GeneralPrefs Prefs.
    
    The root cause of this problem is that src/cc_queue.c includes system headers
    *before* local header files, thus _GNU_SOURCE will not be set when processing
    regex.h. In src/board.c, however, local header files are processed first,
    resulting in different expansions of global.h.
    
    Best, Michael
---
 src/cc_queue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cc_queue.c b/src/cc_queue.c
index 5405d4e..1fee2cf 100644
--- a/src/cc_queue.c
+++ b/src/cc_queue.c
@@ -1,7 +1,7 @@
-#include <sys/types.h>
-#include <sys/wait.h>
 #include "coincoin.h"
 #include "site.h"
+#include <sys/types.h>
+#include <sys/wait.h>
 #include <libintl.h>
 #define _(String) gettext (String)
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-wmaker/wmcoincoin.git