[Pkg-wmaker-commits] [wmaker] 04/21: New applications do not create Cached Icon

[Doug Torrance]

This is an automated email from the git hooks/post-receive script.

dtorrance-guest pushed a commit to branch next
in repository wmaker.

commit 9c4b19d8aaee2f80f03853e62c753298edf12ceb
Author: Rodolfo García Peñas (kix) <kix at kix.es>
Date:   Sun Aug 23 20:56:54 2015 +0200

    New applications do not create Cached Icon
    
    This patch avoids to create Cached Icons for all applications. Only
    the applications docked should create it, as Zoltan said:
    
    -------8<-------
    Also app icon caching was broken around the same time. The app icon cache
    in CachedPixmaps was meant to store icons retrieved from X clients so the
    dock or clip can display those when the client is not running like after
    startup. The cache should contain only such icons and the path should never
    appear in WMWindowAttributes because the cache is an internal thing used to
    look up icons not otherwise available. If you look at your WMWindowAttributes
    now it is full of entries referring to the cache that should not be there and
    if you look at the cache dir you'll find a lot of icons from all apps you've
    ever started while there should be only the few docked ones that use client
    side icons. Also the cache is never cleaned up only new icons are added to it.
    -------8<-------
    
    Signed-off-by: Rodolfo García Peñas (kix) <kix at kix.es>
---
 src/appicon.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/appicon.c b/src/appicon.c
index 08331c7..2a9db5c 100644
--- a/src/appicon.c
+++ b/src/appicon.c
@@ -159,9 +159,6 @@ void create_appicon_for_application(WApplication *wapp, WWindow *wwin)
 		if (!WFLAGP(wapp->main_window_desc, no_appicon))
 			paint_app_icon(wapp);
 	}
-
-	/* Save the app_icon in a file */
-	save_appicon(wapp->app_icon, False);
 }
 
 void unpaint_app_icon(WApplication *wapp)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-wmaker/wmaker.git