Bug#403316: [pkg-wpa-devel] Bug#403316: complain on unknown ifupdown directives

[Kel Modderman]

Hi Eduard,

On Saturday 16 December 2006 19:14, Eduard Bloch wrote:
> I just hat to swear once again about wpa_supplicant. After consolidation
> of my config some weeks ago I have kept "wpa-essid" directions there,
> and I assumed that they are correct because nothing complained. However,
> it does not work! wpa-ssid seems to be the correct one but that is not
> obvious, and "essid" is the usual word for it, why should I look for
> "ssid"?

. . . because the wpasupplicant package documentation describes things 
with "ssid" and not "essid".

The configurable options are described at:
/usr/share/doc/wpasupplicant/README.modes.gz

>
> IMO wpa_supplicant should either accept wpa-essid (since those who are
> switching from WEP had wep-essid in the config, not wep-ssid, *sic*), or
> complain about unknown options but not let the user puzzle over the
> weird and unexplainable misbehaviour.

It will accept 'wpa-essid *' with the below patch.

There are just way too many options supported by the wpa_supplicant ifupdown 
hooks to complain on unknown directives, IMHO, unless someone has a bright 
idea for whitelisting the currently supported options without introducing a 
huge maintenance burden (the scripts are aready quite large, at least one 
other person has made that quite clear to me). For this reason, I changed the 
bug title.

Perhaps the script(s) should be a bit more verbose by default?

Thanks, Kel.

Index: functions.sh
===================================================================
--- functions.sh        (revision 777)
+++ functions.sh        (working copy)
@@ -459,6 +459,11 @@
                IF_WPA_AP_SCAN="0"
                wpa_msg verbose "forcing ap_scan=0 (required for wired 
IEEE8021X auth)"
        fi
+
+       if [ -n "$IF_WPA_ESSID" ]; then
+               # #403316, be similar to wireless tools
+               IF_WPA_SSID="$IF_WPA_ESSID"
+       fi

        wpa_cli_do "$IF_WPA_AP_SCAN" raw \
                ap_scan wpa-ap-scan