[pkg-wpa-devel] r982 - in /wpasupplicant/trunk: debian/ debian/ifupdown/ src/common/ wpa_supplicant/ wpa_supplicant/doc/docbook/

[Kel Modderman]

On Tuesday 08 January 2008 17:14:14 Reinhard Tartler wrote:
> Kel Modderman <kel at otaku42.de> writes:
> > On Tuesday 08 January 2008 02:20:29 Reinhard Tartler wrote:
> >> kelmo-guest at users.alioth.debian.org writes:
> >> > Author: kelmo-guest
> >> > Date: Wed Jan  2 11:50:31 2008
> >> > New Revision: 982
> >> >
> >> > URL: http://svn.debian.org/wsvn/pkg-wpa/?sc=1&rev=982
> >> > Log:
> >> > * New upstream release.
> >> >
> >> > Added:
> >> >     wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_background.8
> >> >       - copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_ba ckground.8 wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_cli.8
> >> > - copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_cl i.8 wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_gui.8
> >> >       - copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_gu i.8 wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_passphrase.8
> >> > - copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_pa ssphrase.8
> >> > wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_priv.8 - copied
> >> > unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_pr iv.8
> >> > wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_supplicant.8 -
> >> > copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_su pplicant.8
> >> > wpasupplicant/trunk/wpa_supplicant/doc/docbook/wpa_supplicant.conf.5 -
> >>
> >> This is a very large commit that makes reviewing it rather hard. Please
> >> consider splitting such commits into smaller ones.
> >
> > You want me to commit new upstream releases in pieces? I think you
> > misunderstood the reason for the commit.
> >
> >> > copied unchanged from r981,
> >> > wpasupplicant/branches/upstream/current/wpa_supplicant/doc/docbook/wpa
> >> >_su pplicant.conf.5 Modified:
>
> These files are certainly not part of the new upstrema release:
> >> >     wpasupplicant/trunk/debian/changelog
> >> >     wpasupplicant/trunk/debian/control
> >> >     wpasupplicant/trunk/debian/ifupdown/functions.sh
> >> >     wpasupplicant/trunk/debian/rules

But for the Subversion snapshot to remain building with new release, these 
files required modification ( the manpage building stuff ).

Basically, I try very hard to make each commit sane for a long long time now, 
sometimes I make mistakes and redo, but getting questioned like this gets my 
defenses up a bit. Sorry for that.

>
> But these are:
> >> >     wpasupplicant/trunk/src/common/version.h
> >> >     wpasupplicant/trunk/wpa_supplicant/ChangeLog
> >> >     wpasupplicant/trunk/wpa_supplicant/nmake.mak
> >>
> >> I notice that the manpages are no longer beeing built but pregenerated
> >> manpages have been added. May I ask for the reason? Do the generated
> >> ones differ from the precompiled ones?
> >
> > See debian/README.Debian-Source for the reasoning. I've also started some
> > work in debian/patches to send upstream. On top of that I plan to embed
> > some debian specific tips into the manual pages.
>
> Ah, I see. Wouldn't it be less maintenance work (and easier for upstream
> to merge) if the debian specific parts would be placed in a seperate
> manpage?

Ok. A good idea. A Debian/Ubuntu specific manual page would be ok, if not a 
bit of duplicated work. Actually, it would be nice to write the README.modes 
up in a nicer format than text file and distribute it.

git snapshots of wpa_supplicant do not provide pre-built manual pages, 
released tarballs do. This is tricky to handle, so I've made my best proposal 
(removing them from our package without modification of released upstream 
tarball) and also saw opportunity to wedge in a few debian/ubuntu specific 
hints.

I would also like to give Jouni a bit of a hand with the docs this year, and 
can work on this through our packaging. He's been hapilly accepting a few 
patches in recent weeks, I'd like to try and take advantage of that.

The patches are currently broken up into pieces, no debian specific ones exist 
at this time. It was my intention to merge a few changes upstream before 
going full scale with debian/ubuntu stuff.

Thanks, Kel.