[pkg-wpa-devel] Bug#557344: /etc/pm/sleep.d/action_wpa doesn't follow normal pm-utils conventions

[Kel Modderman]

tags 548995 pending
tags 557344 pending
thanks

Hi Enrico,

On Sunday 22 November 2009 00:41:45 Enrico Zini wrote:
> Package: wpasupplicant
> Version: 0.6.9-3
> Severity: normal
> 
> Hello,
> 
> /etc/pm/sleep.d/action_wpa does not follow normal pm-utils conventions
> in two ways:
> 
>  1. Its name does not start with a number. man pm-suspend gives a rather
>     precise convention for script naming:
> 
>        00 - 49
> 	   User and most package supplied hooks. If a hook assumes that
> 	   all of the usual services and userspace infrastructure is
> 	   still running, it should be here.
>        50 - 74
> 	   Service handling hooks. Hooks that start or stop a service
> 	   belong in this range. At or before 50, hooks can assume that
> 	   all services are still enabled.
>        75 - 89
> 	   Module and non-core hardware handling. If a hook needs to
> 	   load/unload a module, or if it needs to place non-video
> 	   hardware that would otherwise break suspend or hibernate into
> 	   a safe state, it belongs in this range. At or before 75,
> 	   hooks can assume all modules are still loaded.
>        90 - 99
>            Reserved for critical suspend hooks.
> 
>     action_wpa, not starting with a number, has an even greater order
>     than 99, and gets run after (and before, during resume) critical
>     suspend hooks. This may mean, for example, that the network modules
>     are not loaded when action_wpa runs.
> 
>  2. the package ships its default hook in /etc/pm/sleep.d instead of
>     /usr/lib/pm-utils/sleep.d/ like every other package does. The reason
>     for shipping the default version in /usr/lib/pm-utils/sleep.d/ is so
>     that it is possible to overriding it with a script in
>     /etc/pm/sleep.d without triggering dpkg's "a config file has
>     changed" prompt during upgrades. Also, it makes it easy to disable
>     the script by just creating a nonexecutable file with the same name
>     in /etc/pm/sleep.d
> 
> So, please prepend an appropriate number to the hook name, and please
> install it in /usr/lib/pm-utils/sleep.d/ instead of /etc/pm/sleep.d

This is all fixed in the VCS which stages the next upload already, as addressed
by #548995 and LP: #307493

Feel free to do a debcheckout and check that it is fixed correctly.

Thanks, Kel.