[pkg-wpa-devel] Bug#582793: Bug#582793: wpagui: use knotify to display notifications when running under KDE

[Raphael Geissert]

Hi Kel,

On 24 May 2010 07:54, Kel Modderman <kel at otaku42.de> wrote:
> On Monday 24 May 2010 03:54:37 Raphael Geissert wrote:
>> It falls back to QSystemTray's showMessage() if something went wrong when
>> starting kdialog(1).
>
> But it doesn't fallback if kdialog starts but ultimately fails (eq, run as
> root -> kdialog(...): Session bus not found). This does:
> ---
>                if (QProcess::execute("/usr/bin/kdialog", args) == 0)
>                    return;
>        }
>
>        if (!QSystemTrayIcon::supportsMessages())
>                return;
> ---

Right, but there are two things that need to be considered:
a) QProcess::execute() waits until the process finishes, which can
make wpagui freeze until knotify takes the dbus message. Or at least
that's what used to happen with dcop-based messaging.
b) Running it as root should be a no-no :)

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net