[pkg-wpa-devel] Bug#657332: Please enabled hardened build flags

[Kel Modderman]

tags 657332 pending
thanks

> On Wed, Jan 25, 2012 at 06:44:52PM +0100, Moritz Muehlenhoff wrote:
> > Package: hostapd
> > Version: 1:0.7.3-4
> > Severity: important
> > Tags: patch
> > 
> > Please enabled hardened build flags through dpkg-buildflags.
> > 
> > Patch attached.
> 
> What's the status? Do you plan an upload in the next weeks or
> shall I upload a NMU?

Hi Moritz,

We plan to do an upload with much larger changes in mind, we will
include the below changes which should have similar effect to what you
proposed:
---
Index: debian/rules
===================================================================
--- debian/rules        (revision 1712)
+++ debian/rules        (working copy)
@@ -1,9 +1,11 @@
 #!/usr/bin/make -f
 
-CFLAGS   = -MMD -Wall -g
+CFLAGS   = -MMD -Wall
+CFLAGS   += $(shell dpkg-buildflags --get CFLAGS)
+CPPFLAGS += $(shell dpkg-buildflags --get CPPFLAGS)
+CXXFLAGS =  $(shell dpkg-buildflags --get CXXFLAGS)
 UCFLAGS  = -MMD -Wall -g -Os
-CXXFLAGS = -g
-LDFLAGS  = -Wl,--as-needed
+LDFLAGS  =  $(shell dpkg-buildflags --get LDFLAGS),--as-needed
 BINDIR   = /sbin
 V = 0
 
@@ -15,7 +17,7 @@
        CXXFLAGS += -O2
 endif
 
-export CFLAGS CXXFLAGS LDFLAGS BINDIR V
+export CFLAGS CPPFLAGS CXXFLAGS LDFLAGS BINDIR V
 
 DEB_HOST_ARCH_OS              ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
 HOSTAPD_DOT_CONFIG            := debian/config/hostapd/$(DEB_HOST_ARCH_OS)
---

Thanks, Kel