[pkg-wpa-devel] Bug#718651: Built hostapd/wpasupplicant 2.1 (patch)

[Stefan Lippers-Hollmann]

Hi

On Monday 02 June 2014, Gerald Turner wrote:
> Stefan Lippers-Hollmann <s.L-H at gmx.de> writes:
> > On Saturday 31 May 2014, Stefan Lippers-Hollmann wrote:
> >> On Saturday 31 May 2014, Gerald Turner wrote:
> >> > Stefan Lippers-Hollmann <s.L-H at gmx.de> writes:
> >> > > On Saturday 31 May 2014, Gerald Turner wrote:
> > [...]
> >> > Would you like me to spend some time reconstructing a DEP-5
> >> > copyright file for 2.1, or would that also be wasted effort?
> >>
> >> It doesn't make sense to start collecting the copyright information
> >> from the 2.1 release, as meanwhile 28 files changed their copyright
> >> (new years, typically 2014, added), 24 new files were added + the
> >> whole new subdirectory hs20/ (which is fortunately licensed rather
> >> uniformly) and with 6 files being completely removed. If we already
> >> had this DEP-5 listing for 2.1, it would be reasonable to update it,
> >> but when starting from scratch, it only makes sense to start from
> >> current upstream HEAD (and then to use git diff <hash>..hostap_2_2,
> >> to fill up the gaps until v2.1 gets tagged. I'm not asking you to
> >> spend time on this, as I know far too well how demotivating this is,
> >> but I certainly wouldn't say no to a patch either.
> >
> > Just as a hint, I have just[1] updated debian/get-orig-source to work
> > with wpa 2.2~. Using a version number like e.g.
> > 	2.1+git20140531.1+147848e-1
> > then fetches the according upstream tarball.
> 
> Well, I've done it, and it sure was tedious!
> 
> Steps:
> 
>   git log --full-diff -p hostapd hs20 patches src wpa_supplicant | \
>     egrep '(^diff|Copyright)' | \
>     grep -B1 Copyright | \
>     ./git-log-full-diff-parse-copyright
> 
> The Perl script (attached) took a few hours to write - there's a brick
> of about 60 lines to munge file moves.  Then about another hour to
> inspect all that output, plus poking at each file to make sure that the
> license change actually occured.

I've just finished cross-checking debian/copyright and ended up with 
the attached diff[1]. A few differences can be attributed to slightly
different collation methods, some add copyright information which is
hard to parse/ find automatically and some add information that your
parser appears to have missed.

By the way, I've disabled Hotspot 2.0 support for now, as it appears
to require a PHP- and webserver for the server part (hostapd), which
would require quite significant packaging changes that would need 
confirmation (and efforts) of someone who actually intends to use it.

Likewise I've disabled SQLITE support for hostapd, while hostapd isn't
as size sensitive (nor critical in regards to its FHS location) as 
wpa_supplicant would be, adding sqlite seems just to optimise managing
of the eap_user database, which is also available in a (duplicate) text
file format. IMHO this can be left disabled, until anyone actually 
needs it and presents a use case requiring this functionality.

If you did enable those symbols for a specific reason other than them
just being there in the new version, please give me a hint.

Regards
	Stefan Lippers-Hollmann

[1]	http://anonscm.debian.org/viewvc/pkg-wpa/wpa/trunk/debian/copyright?revision=1881&view=markup
-------------- next part --------------
A non-text attachment was scrubbed...
Name: copyright.diff
Type: text/x-patch
Size: 13901 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20140701/0260e713/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20140701/0260e713/attachment-0001.sig>