[pkg-wpa-devel] Bug#780552: Bug#780552: wpa_supplicant.service needs Before=network.target to ensure proper ordering on shutdown

[Stefan Lippers-Hollmann]

Hi

On 2015-03-16, Michael Biebl wrote:
> Package: wpasupplicant
> Version: 2.3-1
> Severity: important
> 
> Hi,
> 
> please add a Before=network.target dependency
> to the [Unit] section of wpa_supplicant.service. This ensures, that
> wpa_supplicant is stopped on shutdown *after* remote mount points have
> been unmounted. See also the discussion at [1].

Thanks a lot for reporting this, even more for hinting at the solution :)

Looking at it more thoroughly, I think "After=syslog.target" might be
needed as well, given that (by default) wpa_supplicant uses the syslog
facilities for logging purposes. Therefore I'd suggest this patch 
instead:

### snip ###
wpasupplicant: fix systemd unit dependencies

wpasupplicant needs to be started before the network target
(Closes: 780552).

Debian bug: https://bugs.debian.org/780552
Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769186#41
systemd upstream bug: https://bugs.freedesktop.org/show_bug.cgi?id=86707#c3

Signed-off-by: Stefan Lippers-Hollmann <s.l-h at gmx.de>

--- a/wpa_supplicant/systemd/wpa_supplicant.service.in
+++ b/wpa_supplicant/systemd/wpa_supplicant.service.in
@@ -1,5 +1,7 @@
 [Unit]
 Description=WPA supplicant
+Before=network.target
+After=syslog.target
 
 [Service]
 Type=dbus
### snip ###

Do you agree with this evaluation? 

Given the current stage of the freeze[1], would you like to get this
uploaded for jessie? In that case I'll coordinate with release and d-i 
teams after the upload to unstable, pending release and udeb unblock, it 
should migrate without problems.

> Please forward this upstream accordingly.

There are more changes to the systemd units pending for stretch (shipping 
the wpa_supplicant unit[2] needed for networkd, which needs more changes),
I'll wrap these up after preparing the packaging svn for wpa 2.4/ the 
first post-jessie upload and will take care of submitting these to 
upstream.

Regards
	Stefan Lippers-Hollmann

[1]	technically the window for fixing non-RC (==important) bugs has
	already been closed following the current release policy, but
	I'd be fine with asking for an unblock if you'd like to see this
	fixed for jessie with your systemd/ network-manager maintainer 
	hat.
	https://release.debian.org/jessie/freeze_policy.html
[2]	http://w1.fi/cgit/hostap/tree/wpa_supplicant/systemd/wpa_supplicant.service.arg.in
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20150317/dc0434c2/attachment.sig>