[pkg-x2go-devel] Bug#739496: [X2Go-Dev] Issue with 100% cpu usage in x2goclient + libssh 0.6.0

[Reinhard Tartler]

On Sat, May 10, 2014 at 4:07 PM, Mike Gabriel
<mike.gabriel at das-netzwerkteam.de> wrote:
> HI Reinhard,
>
> thanks for your efforts on this!!! The situation around libssh and
> x2goclient is a little tricky and certainly needs a Ubuntu dev to fix those
> issues.

Which I am. What do you need me to do?

>
>
> On  Sa 10 Mai 2014 16:50:55 CEST, Reinhard Tartler wrote:
>
>> Note that x2goclient itself does work, but consumes 100% CPU and makes
>> my fans very loud.
>
>
> Yes, I know that / have heard of that.
>
>
>> The bug is not present in 4.0.2.1-0~576~ubuntu14.04.1, but it *is* present
>> in
>>
>>  x2goclient | 4.0.1.1-1ubuntu1 | trusty/universe  | source, amd64,
>> armhf, i386, powerpc, ppc64el
>>  libssh-4 | 0.6.1-0ubuntu3         | trusty           | amd64, arm64,
>> armhf, i386, powerpc, ppc64el
>
>
> Ack.
>
>
>> I've verified by installing a clean trusty chroot and installing
>> x2goclient only.
>>
>> I can confirm that updating to x2goclient_4.0.2.0-0~574~ubuntu14.04.1,
>> which is currently in the x2go/stable PPA for saucy fixes the problem.
>>
>> I've tested again in a clean saucy chroot, and this bug is not present
>> there. Most probably because it doesn't ship libssh 0.6.

Please check again. I don't see any of them .


> To this mail I have attached four patches:
>
> 1. x2goclient-reduce-fan-noise-with-libssh-0.6.x.patch
>
> This patch is (IMHO, after some more reading of git diff) needed for X2Go
> Client << 4.0.1.4 to reduce the CPU fan noise when running with a libssh >=
> 0.6.1 under the hood.

I guess that should go to trusty.

> 2. libssh patches that are required with X2Go Client >= 4.0.2.0:
>
> If you want to run an X2Go Client (>= 4.0.2.0) (like the one in our PPA)
> against a libssh (<< 0.6.1) you need these two patches
>
>   0004-reset-global-request-status.patch
>   0005-multi-reverse-fwd.patch

irrelevant, trusty ships 4.0.1.x

>
> 3. Speed improvements:
>
> If you want to get things more rocking and really speed up X2Go via libssh,
> then you need this libssh patch, as well. (I think it entered libssh
> upstream at 0.6.2, but I am not sure):
>
>   0006-ssh-handle-package-zero-timeouts.patch

Also out of scope of this bug.

>> Mike, I've seen that you've uploaded 0.5.4-3~13.10.1 yesterday to
>> saucy's PPA. I fear that users of the PPA will no longer benefit from
>> future ubuntu security updates because you've replaced their system
>> libssh with an updated version.
>
>
> I am aware of this, and
>
>  (a) I co-maintain libssh in Debian, so I notice security issues
>      and uploads at time and CVE-2014-0017 is exactly the reason for my
> recent
>      upload to our X2Go PPAs.
>  (b) X2Go Client will FTBFS without 0005-multi-reverse-fwd.patch, so for
>      provision of recent X2Go Client releases through ppa:x2go/stable
>      I need to provide this patched libssh (taken from Debian) in X2Go's
>      PPAs.

So we not only need a recent libssh, but also carry custom patches? *sigh*


> Yesterday, I finally found the time to upload x2goclient 4.0.2.0-1 to Debian
> unstable and now we can push libssh 0.6.x to unstable, as well.

If you could please upload the patch attached to #739496 to unstable,
then I could sync that package to utopic.



-- 
regards,
    Reinhard