[pkg-x2go-devel] Bug#759079: Bug#759079: pyhoca-gui: patch for wxPython 3.0

[Olly Betts]

On Sat, Sep 20, 2014 at 08:37:12AM +0200, Mike Gabriel wrote:
> Once this segfault issue has been fixed, the upstream release is due.
> I haven't had time to investigate this, yet. Any input from your side
> (with more wx expertise than mine) will be appreciated.

I can certainly take a look.

> Can you confirm that pyhoca-gui 0.4.0.9 with you patch attached to
> this bug comes up without segfault?

I didn't segfault on me - I wasn't able to figure out how to set it up
to really test it, but it started up OK.

> You can test pyhoca-gui 0.5.0.0 (preview) via this DebURL [3].

Are these the source packages I should be looking at (dated Sep 15th):

http://packages.x2go.org/debian/pool/heuler/p/pyhoca-gui/

> [1] http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=3f6545b82aeee842ada53a79e4583a3d09da562d

In 2.8, wx.InitAllImageHandlers() is a no-op, so since you require at
least 2.8 (via wxversion), there's no point having this special check -
you can just drop the call to wx.InitAllImageHandlers() entirely:

-wx.InitAllImageHandlers()
+if wx.__version__.startswith('2.')
+    wx.InitAllImageHandlers()

And similarly, wx.FD_OPEN, etc work in 2.8, so this version check isn't
necessary:

+        if wx.__version__.startswith('2.'):
+            _style = wx.OPEN | wx.CHANGE_DIR
+        else:
+            _style = wx.FD_OPEN | wx.FD_CHANGE_DIR

If you wanted to support 2.6, you'd probably need both of these version
checks, but the calls to wxversion.select(['3.0', '2.9', '2.8']) mean
the code won't run under 2.6 anyway.

The code as it is after that commit should work - it's just
unnecessarily complicated.

Cheers,
    Olly