[Pkg-xfce-devel] Bug#455870: thunar-volman: music player command started not only for music players

[Tino Keitel]

Package: thunar-volman
Version: 0.2.0-1scorpi0
Severity: normal
Tags: patch

Hi,

I set gtkpod as the music player command in thunar-volman. Now gtkpod starts
when I:

- plug in my iPod (good)

- plug in my external firewire hard disk (bad)

- plug in my USB card reader with the CF from the camera (bad)

- insert a DVD (bad)

This reason is that the HAL check for the "portable_audio_player" property
is done, but the result is ignored.

I attached a minimal, straightforwarded patch that starts the music player
command only devices that are reported as a "portable_audio_player"

This corresponds to http://bugzilla.xfce.org/show_bug.cgi?id=2856.

Regards,
Tino
-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23.8 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages thunar-volman depends on:
ii  libatk1.0-0             1.20.0-1         The ATK accessibility toolkit
ii  libc6                   2.7-4            GNU C Library: Shared libraries
ii  libcairo2               1.4.10-1.2       The Cairo 2D vector graphics libra
ii  libdbus-1-3             1.1.2-1          simple interprocess messaging syst
ii  libdbus-glib-1-2        0.74-1           simple interprocess messaging syst
ii  libexo-0.3-0            0.3.4-1          Library with extensions for Xfce
ii  libfontconfig1          2.5.0-2          generic font configuration library
ii  libfreetype6            2.3.5-1+b1       FreeType 2 font engine, shared lib
ii  libglib2.0-0            2.14.4-2         The GLib library of C routines
ii  libgtk2.0-0             2.12.3-1         The GTK+ graphical user interface 
ii  libhal-storage1         0.5.10-4         Hardware Abstraction Layer - share
ii  libhal1                 0.5.10-4         Hardware Abstraction Layer - share
ii  libpango1.0-0           1.18.3-1         Layout and rendering of internatio
ii  libpng12-0              1.2.15~beta5-3   PNG library - runtime
ii  libthunar-vfs-1-2       0.9.0-1scorpi0   VFS abstraction used in thunar
ii  libx11-6                2:1.0.3-7        X11 client-side library
ii  libxfce4util4           4.4.2-1          Utility functions library for Xfce
ii  libxrender1             1:0.9.4-1        X Rendering Extension client libra
ii  thunar                  0.9.0-1scorpi0   File Manager for Xfce
ii  zlib1g                  1:1.2.3.3.dfsg-7 compression library - runtime

thunar-volman recommends no packages.

-- debconf-show failed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thunar-volman-audio-player-detection.diff
Type: text/x-c
Size: 1124 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20071212/87236605/attachment.bin