[Pkg-xfce-devel] Bug#507716: xfwm4: broken "focus follows mouse" behavior on raise

[Jason Kraftcheck]

Package: xfwm4
Version: 4.4.2-5
Severity: important


Whenever a window is raised to the top, xfwm4 gives keyboard focus to that
window.  This is incorrect if "focus follows mouse" behavior is requested.

I specified the severity as 'important' rather than 'normal' because this
bug makes xfwm4 unusable in some cases.  For example, one can step through
code in gdb and have the corresponding line highlighted in an editor by
using the editor in client/server mode and invoking the client (e.g. 
emacsclient or nedit-nc) from a hook-stop defined in gdb.  This mode of 
debugging is unworkable if the WM moves focus from the window under the
mouse (gdb in an xterm) to the source code editor all the time.  

This patch corrects the problem:


--- xfwm4-4.4.2/src/client.c	2007-11-17 13:32:13.000000000 -0600
+++ xfwm4-mod/src/client.c	2008-12-03 15:02:41.000000000 -0600
@@ -2638,7 +2638,10 @@
         }
         clientShow (c, TRUE);
         clientClearAllShowDesktop (screen_info);
-        clientSetFocus (screen_info, c, timestamp, NO_FOCUS_FLAG);
+        if (screen_info->params->click_to_focus)
+        {
+            clientSetFocus (screen_info, c, timestamp, NO_FOCUS_FLAG);
+        }
         clientRaise (c, None);
     }
     else


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages xfwm4 depends on:
ii  libatk1.0-0            1.22.0-1          The ATK accessibility toolkit
ii  libc6                  2.7-16            GNU C Library: Shared libraries
ii  libcairo2              1.6.4-6.1         The Cairo 2D vector graphics libra
ii  libfontconfig1         2.6.0-3           generic font configuration library
ii  libfreetype6           2.3.7-2           FreeType 2 font engine, shared lib
ii  libglib2.0-0           2.16.6-1          The GLib library of C routines
ii  libgtk2.0-0            2.12.11-4         The GTK+ graphical user interface 
ii  libice6                2:1.0.4-1         X11 Inter-Client Exchange library
ii  libpango1.0-0          1.20.5-3          Layout and rendering of internatio
ii  libpixman-1-0          0.10.0-2          pixel-manipulation library for X a
ii  libpng12-0             1.2.27-2          PNG library - runtime
ii  libsm6                 2:1.0.3-2         X11 Session Management library
ii  libstartup-notificatio 0.9-1             library for program launch feedbac
ii  libx11-6               2:1.1.5-2         X11 client-side library
ii  libxcomposite1         1:0.4.0-3         X11 Composite extension library
ii  libxdamage1            1:1.1.1-4         X11 damaged region extension libra
ii  libxext6               2:1.0.4-1         X11 miscellaneous extension librar
ii  libxfce4mcs-client3    4.4.2-4           Client library for Xfce4 configure
ii  libxfce4mcs-manager3   4.4.2-4           Manager library for Xfce4 configur
ii  libxfce4util4          4.4.2-3           Utility functions library for Xfce
ii  libxfcegui4-4          4.4.2-4           Basic GUI C functions for Xfce4
ii  libxfixes3             1:4.0.3-2         X11 miscellaneous 'fixes' extensio
ii  libxrandr2             2:1.2.3-1         X11 RandR extension library
ii  libxrender1            1:0.9.4-2         X Rendering Extension client libra
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

Versions of packages xfwm4 recommends:
ii  librsvg2-common               2.22.2-2   SAX-based renderer library for SVG
ii  xfce4-mcs-manager             4.4.2-3    Settings manager for Xfce4
ii  xfwm4-themes                  4.4.2-1    Theme files for xfwm4

Versions of packages xfwm4 suggests:
ii  xfce4                         4.4.2.1    Meta-package for the Xfce Lightwei

-- no debconf information