[Pkg-xfce-devel] Bug#522729: Processed: reassign to xfce4-notifyd

Evgeni Golov evgeni at debian.org
Fri May 8 22:05:08 UTC 2009


tags 522729 + patch
thanks

On Fri, 08 May 2009 13:18:32 +0800 Chow Loong Jin wrote:

> Digging through the ChangeLog of xfce4-notifyd reveals this:
> 2008-09-20      Brian J. Tarricone <bjt23 at cornell.edu>
> 
>         * xfce4-notifyd/xfce-notify-daemon.c: don't send the 2nd argument
>           (close reason) with the NotificationClosed signal for some reason libnotify doesn't support it, so apps don't receive
>           the signal.  lovely.
> 
> However, digging through libnotify's source code reveals this:
> static void
> _close_signal_handler(DBusGProxy *proxy, guint32 id, guint32 reason,
>                                           NotifyNotification *notification)
> 
> Although I haven't tested it, I would believe that libnotify does indeed
> support the 2nd argument, as of now. I think it would be a good idea to
> pass the close reason with the NotificationClosed signal now, at least
> in Debian and Ubuntu.

Right, I installed banshee and reproduced your bug. After playing with
Corsac initial patch, I noticed that he somehow missed the point and
fixed it :) Would you please test
http://die-welt.net/~evgeni/xfce4-notifyd_0.1.0-3_amd64.deb
and tell me that the bug is gone (it is for me).

If it is, I'll ask upstream on his opinion and upload a fixed package
ASAP.

Regards
Evgeni

-- 
Bruce Schneier Fact Number 623:
The only fully secure symmetric cryptosystem is Bruce Schneier looking
in a mirror.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20090509/6fda3273/attachment-0001.pgp>


More information about the Pkg-xfce-devel mailing list