[Pkg-xfce-devel] Bug#629265: Bug#629265: Bug#629265: Bug#629265: Bug#629265: Broken empty battery icon on system tray

[Kim Holviala]

On 2011-06-05 20:30, Yves-Alexis Perez wrote:

>> I traced the code a bit and found function xfpm_battery_refresh_icon()
>> which looks a bit fishy. It's the function that converts battery
>> percentage to an icon name.
>
> So you have a tentative fix ready? I can try testing it, I should have a
> mostly empty battery and I think force_discharge with laptop plugged
> should be safe.

Yup, got a working patch. The bug was just shoddy coding - two if loops 
with missing final elses and an uninitalizd string icon_name.

Attached simple patch fixes the if clauses and makes sure the string 
variable is always defined before returning.



- Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfpm-empty-battery-icon.patch
Type: text/x-patch
Size: 888 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20110605/614bf151/attachment.bin>