[Pkg-xfce-devel] Bug#629265: Bug#629265: Broken empty battery icon on system tray

Kim Holviala kim at holviala.com
Sun Jun 5 19:33:23 UTC 2011

On 2011-06-05 22:31, Yves-Alexis Perez wrote:

>> Yup, got a working patch. The bug was just shoddy coding - two if loops
>> with missing final elses and an uninitalizd string icon_name.
>> Attached simple patch fixes the if clauses and makes sure the string
>> variable is always defined before returning.
> Hmhm, I'm not too sure. I'll have to report that upstream and ask for
> advice, but I think it might be better to keep the case and add a new
> one for XFPM_DEVICE_STATE_EMPTY, then a fallback.

I thought about that too, but the code inside the fallback if block 
would be identical...

Another way would be simply to initialize icon_name to something 
sensible (correct percentage image) even before the if clauses.

But I agree that upstream is the correct address for this.

- Kim

More information about the Pkg-xfce-devel mailing list