[Pkg-xfce-devel] Bug#691297: xfce4-netload-plugin: Please release the plugin consistent with and of same quality as other XFCE 4.8 plugins

[Petr Gajdusek]

Package: xfce4-netload-plugin
Version: 1.1.0-1+b1
Severity: important
Tags: upstream patch

Dear Maintainer,

I have switched to XFCE few weeks ago and was happy user of XFCE 4.10. Recently
I decided to downgrade to 4.8 to test the Wheezy. The netload plugin is rather
hard to use, it suffers from several bugs, from which most are fixed in 4:10.
Comparing to other 4.8 monitoring plugins (systemload, fsguard, diskperf) it is
inconsistent and rather low quality.

I have prepared several - hopefully simple and uninvasive - patches to fix some
issues:
- plugin GUI gets totally broken on panel orientation change
- context menu is unaccessible on many situations
- inconsistent padding and border with other plugins: bars are smaller than
bars of other plugins, border width does not adapt to panel size, breaks Panel
HIG [1]
- entries (text input boxes) in preferences require pressing the ENTER or
closing the dialog to be applied - without any feedback user is required to do
that, This breaks Panel HIG [2], is inconsistent with other control widgets
(check boxes, spinners, color choosers) that are applied instantly and with
other plugins.
- default text of the label is "Net" while other plugins use lowercase

I tried to make those patches as simple as I was able to make sure they won't
cause regressions.

Please, consider including them to wheezy.

Thanks,
Petr Gajdůšek

[1] https://wiki.xfce.org/dev/hig/panel-plugins#widgets_paddingsize
[2] https://wiki.xfce.org/dev/hig/panel-plugins#properties_dialog



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (1001, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=cs_CZ.utf8, LC_CTYPE=cs_CZ.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xfce4-netload-plugin depends on:
ii  libc6               2.13-35
ii  libcairo2           1.12.2-2
ii  libgdk-pixbuf2.0-0  2.26.1-1
ii  libglib2.0-0        2.33.12+really2.32.4-2
ii  libgtk2.0-0         2.24.10-2
ii  libxfce4ui-1-0      4.8.1-1
ii  libxfce4util4       4.8.2-1
ii  xfce4-panel         4.8.6-4

xfce4-netload-plugin recommends no packages.

xfce4-netload-plugin suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Preserve-widgets-visibility-on-orientation-change.patch
Type: text/x-diff
Size: 2825 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Keep-colorized-values-after-orientation-change.patch
Type: text/x-diff
Size: 1510 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-context-menu-not-accessible-by-right-clicking-on.patch
Type: text/x-diff
Size: 2100 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Properly-set-padding-and-border-width.patch
Type: text/x-diff
Size: 3574 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Preferences-commit-changes-of-label-and-maximum-valu.patch
Type: text/x-diff
Size: 2358 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Change-default-label-text-from-Net-to-net.patch
Type: text/x-diff
Size: 725 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121024/96942fc2/attachment-0005.patch>