[Pkg-xfce-devel] Comments regarding xfce4-netspeed-plugin_0.3.1-1_amd64.changes

Gergely Nagy ftpmaster at ftp-master.debian.org
Sun Nov 3 16:17:18 UTC 2013


Hi!

While reviewing your upload of xfce4-netspeed-plugin in the NEW queue,
I came accross a few issues:

* The PNG icons under icons/ have a note that they're exported from
  Inkscape. Can you ask upstream to either include the original SVG,
  or verify that the pngs are the preferred form of modification?

* The upstream ChangeLog is empty, so the debian package ends up with
  an empty one too. I would suggest removing it from the package, as
  it is useless.

  You can also tell upstream to use the foreign flag for automake, so
  it won't nag about missing ChangeLog and NEWS files and the likes.
  (One can use the foreign flag for AM_INIT_AUTOMAKE in configure.ac
  to achieve this)

* Another upstream "issue" is that there's a dist-bz2 target, which
  zcats the tarball and recompresses. Instead, the dist-bz2 option
  could be used in AM_INIT_AUTOMAKE to do it the standard way.

I'm holding the package in the queue until the icon issues are
resolved.





More information about the Pkg-xfce-devel mailing list